From 5e9ded6843a720a4d234ba63143d14e05f4746b4 Mon Sep 17 00:00:00 2001 From: Andre Noll Date: Thu, 25 Jul 2013 00:43:28 +0200 Subject: [PATCH 1/1] mood: Simplify compute_dynamic_score(). Never use one housekeeping variable when you could just as easily use two or three. - Roedy Green: How To Write Unmaintainable Code --- mood.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/mood.c b/mood.c index 833820a8..e60ef2fd 100644 --- a/mood.c +++ b/mood.c @@ -477,16 +477,10 @@ static long compute_last_played_score(struct afs_info *afsi) static long compute_dynamic_score(const struct osl_row *aft_row) { struct afs_info afsi; - int64_t score, nscore = 0, lscore = 0; - int ret; - ret = get_afsi_of_row(aft_row, &afsi); - if (ret < 0) + if (get_afsi_of_row(aft_row, &afsi) < 0) return -100; - nscore = compute_num_played_score(&afsi); - lscore = compute_last_played_score(&afsi); - score = nscore + lscore; - return score; + return compute_num_played_score(&afsi) + compute_last_played_score(&afsi); } static int add_afs_statistics(const struct osl_row *row) -- 2.39.2