From 6761a4b76e3e7534ead2021cee9bab41716d4488 Mon Sep 17 00:00:00 2001 From: Andre Noll Date: Sun, 27 Oct 2013 11:24:43 +0100 Subject: [PATCH] afh: Unmap the audio file on errors. If compute_afhi() returns negative we miss to call para_munmap() to unmap the audio file. This is not a serious bug since we exit anyway in this case. --- afh.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/afh.c b/afh.c index d06e4420..49629cb1 100644 --- a/afh.c +++ b/afh.c @@ -102,16 +102,15 @@ int main(int argc, char **argv) } ret = compute_afhi(conf.inputs[i], audio_file_data, audio_file_size, fd, &afhi); - if (ret < 0) - goto out; - - audio_format_num = ret; - printf("File %d: %s\n", i + 1, conf.inputs[i]); - print_info(audio_format_num, &afhi); - if (conf.chunk_table_given) - print_chunk_table(&afhi); - printf("\n"); - clear_afhi(&afhi); + if (ret >= 0) { + audio_format_num = ret; + printf("File %d: %s\n", i + 1, conf.inputs[i]); + print_info(audio_format_num, &afhi); + if (conf.chunk_table_given) + print_chunk_table(&afhi); + printf("\n"); + clear_afhi(&afhi); + } ret2 = para_munmap(audio_file_data, audio_file_size); if (ret2 < 0 && ret >= 0) ret = ret2; -- 2.39.2