From 8529eea3d452cbe151239edc6461bfd5c2655b5b Mon Sep 17 00:00:00 2001
From: Andre Noll <maan@tuebingen.mpg.de>
Date: Wed, 1 Apr 2015 02:55:50 +0000
Subject: [PATCH 1/1] bitstream.c: Convert GET_DATA macro to inline function.

There is no benefit from defining this as a macro. With the inline
function we get type safety for free, and the new version is better
readable.
---
 bitstream.c | 36 +++++++++++++++++++-----------------
 1 file changed, 19 insertions(+), 17 deletions(-)

diff --git a/bitstream.c b/bitstream.c
index cf815598..1593b99e 100644
--- a/bitstream.c
+++ b/bitstream.c
@@ -21,21 +21,23 @@
 #include "wma.h"
 #include "bitstream.h"
 
-/** Read an 8, 16, or 32 bit entity from a VLC table. */
-#define GET_DATA(v, table, i, size) \
-{\
-	const uint8_t *ptr = (const uint8_t *)table + i * size; \
-	switch (size) { \
-	case 1: \
-		v = *(const uint8_t *)ptr; \
-		break; \
-	case 2: \
-		v = *(const uint16_t *)ptr; \
-		break; \
-	default: \
-		v = *(const uint32_t *)ptr; \
-		break; \
-	} \
+static inline uint32_t get_data(const void *table, int i, int size)
+{
+	const uint8_t *ptr = (const uint8_t *)table + i * size;
+	uint32_t v;
+
+	switch (size) {
+	case 1:
+		v = *(const uint8_t *)ptr;
+		break;
+	case 2:
+		v = *(const uint16_t *)ptr;
+		break;
+	default:
+		v = *(const uint32_t *)ptr;
+		break;
+	}
+	return v;
 }
 
 static void alloc_table(struct vlc *vlc, int size)
@@ -68,12 +70,12 @@ static int build_table(struct vlc *vlc, int table_nb_bits, int nb_codes,
 
 	/* map codes and compute auxiliary table sizes */
 	for (i = 0; i < nb_codes; i++) {
-		GET_DATA(n, bits, i, 1);
+		n = get_data(bits, i, 1);
 		/* we accept tables with holes */
 		n -= n_prefix;
 		if (n <= 0)
 			continue;
-		GET_DATA(code, codes, i, codes_size);
+		code = get_data(codes, i, codes_size);
 		/* if code matches the prefix, it is in the table */
 		if ((code >> n) != code_prefix)
 			continue;
-- 
2.39.2