From 945502385e8261d6921c7e1748fa64f34b7b81fd Mon Sep 17 00:00:00 2001 From: Andre Noll Date: Sat, 28 Aug 2021 20:53:23 +0200 Subject: [PATCH] mp4: Rename mp4_open_read() to mp4_open(). The function may be called with the intention to update the meta tags later by calling mp4_update_meta(), albeit mp4_open_meta() is cheaper if the caller only wants to modify the metadata. The old name is thus slightly misleading, and it's longer. --- aac_afh.c | 2 +- mp4.c | 2 +- mp4.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/aac_afh.c b/aac_afh.c index 30e52fcd..7be441ab 100644 --- a/aac_afh.c +++ b/aac_afh.c @@ -68,7 +68,7 @@ static int aac_afh_open(const void *map, size_t mapsize, void **afh_context) c->cb.seek = aac_afh_seek_cb; c->cb.user_data = c; - ret = mp4_open_read(&c->cb, &c->mp4); + ret = mp4_open(&c->cb, &c->mp4); if (ret < 0) goto free_ctx; *afh_context = c; diff --git a/mp4.c b/mp4.c index 02294265..2121155c 100644 --- a/mp4.c +++ b/mp4.c @@ -617,7 +617,7 @@ fail: return ret; } -int mp4_open_read(const struct mp4_callback *cb, struct mp4 **result) +int mp4_open(const struct mp4_callback *cb, struct mp4 **result) { struct mp4 *f; int ret; diff --git a/mp4.h b/mp4.h index 4c4aed22..c6f53ebc 100644 --- a/mp4.h +++ b/mp4.h @@ -19,7 +19,7 @@ struct mp4_metadata { struct mp4; /* opaque */ int mp4_set_sample_position(struct mp4 *f, uint32_t sample); -int mp4_open_read(const struct mp4_callback *cb, struct mp4 **result); +int mp4_open(const struct mp4_callback *cb, struct mp4 **result); void mp4_close(struct mp4 *f); int mp4_get_sample_size(const struct mp4 *f, uint32_t sample, uint32_t *result); uint16_t mp4_get_sample_rate(const struct mp4 *f); -- 2.39.2