From b8290b7cad010552873c5e640e56dbe9c901dfb1 Mon Sep 17 00:00:00 2001 From: Andre Noll Date: Tue, 31 Dec 2013 17:20:24 +0000 Subject: [PATCH] Don't set t->error in ->pre_select(). ->pre_select() methods should never fail, and tasks should not set this variable at all. It is ignored anyway when set there. --- dccp_recv.c | 1 - filter_common.c | 1 - recv_common.c | 1 - wav_filter.c | 1 - 4 files changed, 4 deletions(-) diff --git a/dccp_recv.c b/dccp_recv.c index 796a7e6b..3d6588ac 100644 --- a/dccp_recv.c +++ b/dccp_recv.c @@ -123,7 +123,6 @@ static void dccp_recv_pre_select(struct sched *s, struct task *t) { struct receiver_node *rn = container_of(t, struct receiver_node, task); - t->error = 0; if (generic_recv_pre_select(s, t) <= 0) return; para_fd_set(rn->fd, &s->rfds, &s->max_fileno); diff --git a/filter_common.c b/filter_common.c index 8ce66ea8..f2f5799f 100644 --- a/filter_common.c +++ b/filter_common.c @@ -143,7 +143,6 @@ void generic_filter_pre_select(struct sched *s, struct task *t) { struct filter_node *fn = container_of(t, struct filter_node, task); - t->error = 0; if (btr_node_status(fn->btrn, fn->min_iqs, BTR_NT_INTERNAL) != 0) sched_min_delay(s); } diff --git a/recv_common.c b/recv_common.c index 2d6aa74a..eb5fe57e 100644 --- a/recv_common.c +++ b/recv_common.c @@ -130,7 +130,6 @@ int generic_recv_pre_select(struct sched *s, struct task *t) struct receiver_node *rn = container_of(t, struct receiver_node, task); int ret = btr_node_status(rn->btrn, 0, BTR_NT_ROOT); - t->error = 0; if (ret < 0) sched_min_delay(s); return ret; diff --git a/wav_filter.c b/wav_filter.c index ea3236c7..bd676958 100644 --- a/wav_filter.c +++ b/wav_filter.c @@ -68,7 +68,6 @@ static void wav_pre_select(struct sched *s, struct task *t) struct filter_node *fn = container_of(t, struct filter_node, task); size_t iqs = btr_get_input_queue_size(fn->btrn); - t->error = 0; if (iqs == 0) return; sched_min_delay(s); -- 2.39.2