X-Git-Url: http://git.tuebingen.mpg.de/?a=blobdiff_plain;f=command.c;h=c56a15822dfaf8a7b165b44480a6adcf90d5e1a3;hb=a5a6446fd1af4a0ad03ef06a3c194d37d6a46acd;hp=00d2c5a61ada8fdcedfad2989e43844265ca46d5;hpb=77e4a76adad60c83811baf1c69fd413a6153528f;p=paraslash.git

diff --git a/command.c b/command.c
index 00d2c5a6..c56a1582 100644
--- a/command.c
+++ b/command.c
@@ -47,12 +47,14 @@ extern struct misc_meta_data *mmd;
 int send_afs_status(struct command_context *cc, int parser_friendly);
 static bool subcmd_should_die;
 
+/*
+ * Don't call PARA_XXX_LOG() here as we might already hold the log mutex. See
+ * generic_signal_handler() for details.
+ */
 static void command_handler_sighandler(int s)
 {
-	if (s != SIGTERM)
-		return;
-	PARA_EMERG_LOG("terminating on signal %d\n", SIGTERM);
-	subcmd_should_die = true;
+	if (s == SIGTERM)
+		subcmd_should_die = true;
 }
 
 /*
@@ -505,6 +507,7 @@ static int com_stat(struct command_context *cc, struct lls_parse_result *lpr)
 	 * while we sleep.
 	 */
 	para_block_signal(SIGTERM);
+	para_block_signal(SIGUSR1);
 	for (;;) {
 		sigset_t set;
 		/*
@@ -536,8 +539,10 @@ static int com_stat(struct command_context *cc, struct lls_parse_result *lpr)
 		 * open a race window similar to the one described above.
 		 */
 		pselect(1, NULL, NULL, NULL, &ts, &set);
-		if (subcmd_should_die)
+		if (subcmd_should_die) {
+			PARA_EMERG_LOG("terminating on SIGTERM\n");
 			goto out;
+		}
 		ret = -E_SERVER_CRASH;
 		if (getppid() == 1)
 			goto out;