Dump the dss configuration on startup and on SIGHUP.

[dss.git] / dss.c

diff --git a/dss.c b/dss.c
index 04fe30c4bb7798ae8a049b9eb46638b278ea3927..c5f636c2ed8b86ad5170c164d3f6e2d4d08d862c 100644 (file)
--- a/dss.c
+++ b/dss.c
@@ -818,9 +818,13 @@ static int check_config(void)
        return 1;
 }
 
+/*
+ * Returns < 0 on errors, 0 if no config file is given and > 0 if the config
+ * file was read successfully.
+ */
 static int parse_config_file(int override)
 {
-       int ret;
+       int ret, config_file_exists;
        char *config_file;
        struct stat statbuf;
        char *old_logfile_arg = NULL;
@@ -839,13 +843,13 @@ static int parse_config_file(int override)
                old_daemon_given = conf.daemon_given;
        }
 
-       ret = stat(config_file, &statbuf);
-       if (ret && conf.config_file_given) {
+       config_file_exists = !stat(config_file, &statbuf);
+       if (!config_file_exists && conf.config_file_given) {
                ret = -ERRNO_TO_DSS_ERROR(errno);
                DSS_ERROR_LOG("failed to stat config file %s\n", config_file);
                goto out;
        }
-       if (!ret) {
+       if (config_file_exists) {
                struct cmdline_parser_params params = {
                        .override = override,
                        .initialize = 0,
@@ -884,7 +888,7 @@ static int parse_config_file(int override)
                log_welcome(conf.loglevel_arg);
        }
        DSS_DEBUG_LOG("loglevel: %d\n", conf.loglevel_arg);
-//     cmdline_parser_dump(logfile? logfile : stdout, &conf);
+       ret = config_file_exists;
 out:
        free(config_file);
        if (ret < 0)
@@ -898,14 +902,24 @@ static int change_to_dest_dir(void)
        return dss_chdir(conf.dest_dir_arg);
 }
 
+static void dump_dss_config(const char *msg)
+{
+       if (conf.loglevel_arg > INFO)
+               return;
+       DSS_INFO_LOG("%s\n", msg);
+       cmdline_parser_dump(logfile? logfile : stderr, &conf);
+}
+
 static int handle_sighup(void)
 {
        int ret;
 
-       DSS_NOTICE_LOG("SIGHUP\n");
+       DSS_NOTICE_LOG("SIGHUP, re-reading config\n");
+       dump_dss_config("current config");
        ret = parse_config_file(1);
        if (ret < 0)
                return ret;
+       dump_dss_config("new config");
        invalidate_next_snapshot_time();
        return change_to_dest_dir();
 }
@@ -1294,8 +1308,23 @@ int main(int argc, char **argv)
        ret = parse_config_file(0);
        if (ret < 0)
                goto out;
+       if (ret == 0) { /* no config file given */
+               /*
+                * Parse the command line options again, but this time check
+                * that all required options are given.
+                */
+               params = (struct cmdline_parser_params) {
+                       .override = 1,
+                       .initialize = 1,
+                       .check_required = 1,
+                       .check_ambiguity = 1,
+                       .print_errors = 1
+               };
+               cmdline_parser_ext(argc, argv, &conf, &params); /* aborts on errors */
+       }
        if (conf.daemon_given)
                daemon_init();
+       dump_dss_config("dss configuration");
        ret = change_to_dest_dir();
        if (ret < 0)
                goto out;