gui: Remember menu position.

[gsu.git] / common

diff --git a/common b/common
index 4e1d115cb8473dd15ccba7c6fac806746cc8e4c7..374b81e0498defc0d6895d3617fe3970f06a3cd3 100644 (file)
--- a/common
+++ b/common
@@ -14,11 +14,13 @@ E_GSU_BAD_BOOL                      bad value for boolian option
 E_GSU_BAD_OPTION_TYPE          invalid option type
 E_GSU_BAD_ARG_COUNT            invalid number of arguments
 E_GSU_EDITOR                   failed to execute editor
+E_GSU_INVAL                    invalid argument
 E_GSU_MKDIR                    failed to create directory
 E_GSU_GETOPTS                  getopts error
 E_GSU_DIALOG                   dialog error
 E_GSU_MKTEMP                   mktemp error
 E_GSU_MENU_TREE                        invalid menu tree
+E_GSU_XCMD                     external command failed
 ${gsu_errors:-}
 "
        local a b i=0
@@ -29,7 +31,7 @@ ${gsu_errors:-}
                #echo "a:$a,  b: $b"
                gsu_error_txt[i]="$b"
                eval $a=$i
-               i=$(($i + 1))
+               i=$((i + 1))
        done << EOF
        $gsu_errors
 EOF
@@ -66,15 +68,15 @@ gsu_err_msg()
        local txt="$result" err
 
        gsu_is_a_number "$ret"
-       if (($ret < 0)); then
+       if ((ret < 0)); then
                gsu_msg "unknown error ($ret:$txt)"
                exit 1
        fi
-       if (($result >= 0)); then
+       if ((result >= 0)); then
                gsu_msg "unknown error ($result:$txt)"
                exit 1
        fi
-       err=$((0 - $result))
+       err=$((0 - result))
        if test -n "$txt"; then
                txt="$txt: ${gsu_error_txt[$err]}"
        else
@@ -107,7 +109,7 @@ gsu_make_tempfile()
        if [[ "${template:0:1}" != '/' ]]; then # relative path
                if (($# > 1)); then
                        dir="$2"
-               elif [[ -n "$TMPDIR" ]]; then
+               elif [[ -n "${TMPDIR:-}" ]]; then
                        dir="$TMPDIR"
                else
                        dir="/tmp"