]> git.tuebingen.mpg.de Git - paraslash.git/commit
wmadec: Use read_u32_be().
authorAndre Noll <maan@tuebingen.mpg.de>
Sat, 28 Jan 2017 17:02:33 +0000 (18:02 +0100)
committerAndre Noll <maan@tuebingen.mpg.de>
Sat, 25 Mar 2017 10:58:52 +0000 (11:58 +0100)
commit60a030e4b6c85c0e52acf699189ae29b3873e89b
tree7453ca3bb056e847a6a569983bd2d1889448c801
parent7df8a627b939337d5603fd0a37c4b0cd7b1910c3
wmadec: Use read_u32_be().

The shift operation in show_bits() was buggy because p[0] is promoted
to int, and the shift p[0] << 24 results in undefined behavior,
causing the sanitizer of gcc to complain:

bitstream.h:40:21: runtime error: left shift of 230 by 24 places cannot be represented in type 'int'

read_u32_be() gets this right.
bitstream.c
bitstream.h
wmadec_filter.c