14 years agoFix com_add segfault.
Andre Noll [Thu, 13 Sep 2007 19:55:46 +0000 (21:55 +0200)]
Fix com_add segfault.

We call free( unconditionally on errors, but is is not set to NULL.
Also, return always success in add_one_audio_file() in order to continue the

14 years agoogg_afh.c: Fix a memory leak.
Andre Noll [Thu, 13 Sep 2007 19:53:32 +0000 (21:53 +0200)]
ogg_afh.c: Fix a memory leak.

In an non-ogg file is passed to the ogg audio format handler, such that the
initial ogg_sync_pageout() fails, the old code leaked the memory which was
allocated for the stream_in and the stream_out pointers.

14 years agocom_add: Minor improvements.
Andre Noll [Thu, 13 Sep 2007 17:09:24 +0000 (19:09 +0200)]
com_add: Minor improvements.

Continue if an audio file could not be added and print proper error
message in case of errors.

14 years agoaft.c: Fix com_add().
Andre Noll [Wed, 12 Sep 2007 21:43:16 +0000 (23:43 +0200)]
aft.c: Fix com_add().

callbacks shall return zero or negative, if no result is provided. So let
com_ls_callback() return zero if no match was found, or if the audio file table
does not contain any entries. Check for ret > 0 in com_add() instead of ret >=
0, i.e. don't use the result pointer if ret is zero.

14 years agoafs.c: Fix com_init().
Andre Noll [Wed, 12 Sep 2007 21:39:15 +0000 (23:39 +0200)]
afs.c: Fix com_init().

It didn't use callbacks which worked before the paraslash merge only.

14 years agoafs.c: Add log message, cast sizeof().
Andre Noll [Wed, 12 Sep 2007 17:46:03 +0000 (19:46 +0200)]
afs.c: Add log message, cast sizeof().

In case the local socket could not be created, we really should
tell the user that fact.

The other change in this patch is casting sizeof() to unsigned
long which shuts gcc up on both i386 and x86_64.

14 years agostring.c: Use $HOME to get the home directory.
Andre Noll [Wed, 12 Sep 2007 11:36:20 +0000 (13:36 +0200)]
string.c: Use $HOME to get the home directory.

This is actually simpler than using getpwuid(), and it shuts up a valgrind
warning as well.

14 years agovss_init(): Use FOR_EACH_AUDIO_FORMAT() instead of open coding the loop.
Andre Noll [Wed, 12 Sep 2007 09:23:54 +0000 (11:23 +0200)]
vss_init(): Use FOR_EACH_AUDIO_FORMAT() instead of open coding the loop.

Fixes a segfault on startup in case not all three audio formats are supported.

14 years agoFix afs_shutdown().
Andre Noll [Mon, 10 Sep 2007 21:10:19 +0000 (23:10 +0200)]
Fix afs_shutdown().

Unregister tasks as soon as we catch a terminating signal and call
afs_shutdown() when sched() returns.

14 years agoosl.c: Dereference pointer _after_ checking for NULL.
Andre Noll [Mon, 10 Sep 2007 21:08:35 +0000 (23:08 +0200)]
osl.c: Dereference pointer _after_ checking for NULL.

14 years agoafs: Replace DATABASE_DIR by a runtime config option.
Andre Noll [Mon, 10 Sep 2007 19:52:00 +0000 (21:52 +0200)]
afs: Replace DATABASE_DIR by a runtime config option.

Also, split afs_init() into two parts: The new open_afs_tables() that
does what its name suggests and the remaining part that initializes
the scheduler.

14 years agoafs: Minor improvements and fixes.
Andre Noll [Mon, 10 Sep 2007 00:56:46 +0000 (02:56 +0200)]
afs: Minor improvements and fixes.

- Fix audio format handler output of ls -v.
- add_one_audio_file(): Write log messages to the client fd instead of
  para_server's logfile.

14 years agoFix two typos in documentation.
Andre Noll [Mon, 10 Sep 2007 00:53:52 +0000 (02:53 +0200)]
Fix two typos in documentation.

14 years agoDoxyfile: set EXTRACT_ALL to yes.
Andre Noll [Mon, 10 Sep 2007 00:53:12 +0000 (02:53 +0200)]
Doxyfile: set EXTRACT_ALL to yes.

Otherwise doxygen gives zillions of warnings.

14 years agoAdd a new style file.
Andre Noll [Mon, 10 Sep 2007 00:52:09 +0000 (02:52 +0200)]
Add a new style file.

For v0.3 the outfit should at least change a bit ;)

14 years agoafs com_add(): Recognize also audio formats different from mp3.
Andre Noll [Mon, 10 Sep 2007 00:05:15 +0000 (02:05 +0200)]
afs com_add(): Recognize also audio formats different from mp3.

This required adding two more callbacks: path_brother_callback() and
hash_sister_callback(). These are called from add_one_audio_file()
which runs from handler context and can thus not access the database

14 years agoChange the type of the argv argument of all commands.
Andre Noll [Sun, 9 Sep 2007 17:29:26 +0000 (19:29 +0200)]
Change the type of the argv argument of all commands.

The new type,

char * const * const argv

is what the exec functions also take. This avoids some

14 years agoFix some format string warnings on x86_64.
Andre Noll [Sun, 9 Sep 2007 15:24:13 +0000 (17:24 +0200)]
Fix some format string warnings on x86_64.

14 years agoAdd documentation for com_add().
Andre Noll [Sun, 9 Sep 2007 15:16:43 +0000 (17:16 +0200)]
Add documentation for com_add().

14 years Add to the list of server commands.
Andre Noll [Sun, 9 Sep 2007 15:16:23 +0000 (17:16 +0200)] Add to the list of server commands.

14 years agovss.c: Introduce get_audio_file_info().
Andre Noll [Sun, 9 Sep 2007 12:56:41 +0000 (14:56 +0200)]
vss.c: Introduce get_audio_file_info().

This is going to be used from within aft's com_add() which ATM only
supports mp3.

14 years agoafh.h: Kill unused SUPPORTED_AUDIO_FORMATS_ARRAY.
Andre Noll [Sun, 9 Sep 2007 12:47:59 +0000 (14:47 +0200)]

14 years agoafs.c: Kill unused struct callback_data.
Andre Noll [Sun, 9 Sep 2007 11:15:52 +0000 (13:15 +0200)]
afs.c: Kill unused struct callback_data.

14 years agoAdd a .gitignore file.
Andre Noll [Sun, 9 Sep 2007 11:13:03 +0000 (13:13 +0200)]
Add a .gitignore file.

14 years agoClean up afs.c.
Andre Noll [Sun, 9 Sep 2007 11:12:25 +0000 (13:12 +0200)]
Clean up afs.c.

- Update documentation.
- Kill some dead code.
- Reorder functions.

14 years agoAdd afs.cmd.
Andre Noll [Sun, 9 Sep 2007 09:38:20 +0000 (11:38 +0200)]
Add afs.cmd.

14 years agoMake afs commands work.
Andre Noll [Sat, 8 Sep 2007 23:17:50 +0000 (01:17 +0200)]
Make afs commands work.

This required a rewrite of send_callback_request().

The patch also includes the rename of get_socket() to get_stream_socket()
which takes the new domain parameter, so that it may be used for both
AF_INET and AF_UNIX sockets.

14 years agoIntroduce template commands for
Andre Noll [Sat, 8 Sep 2007 19:50:57 +0000 (21:50 +0200)]
Introduce template commands for

And use them to produce afs_command_list.[ch] which also contains all
blob commands without duplicating all the common information in the
new afs.cmd file.

Change para_server's help command to display the new commands. These
are not yet working because the callback code is not yet functional.

14 years agoImplement server side afs callbacks.
Andre Noll [Sat, 8 Sep 2007 16:34:37 +0000 (18:34 +0200)]
Implement server side  afs callbacks.

Not yet working as the code for contacting afs is still missing.

14 years agoMake struct signal_task generic and make afs use it.
Andre Noll [Sat, 8 Sep 2007 13:49:05 +0000 (15:49 +0200)]
Make struct signal_task generic and make afs use it.

14 years agopara_server: Initialize the new afs.
Andre Noll [Sat, 8 Sep 2007 11:37:11 +0000 (13:37 +0200)]
para_server: Initialize the new afs.

14 years agoFix some signedness warnings.
Andre Noll [Sat, 8 Sep 2007 10:09:49 +0000 (12:09 +0200)]
Fix some signedness warnings.

14 years agoMerge the new afs code.
Andre Noll [Sat, 8 Sep 2007 09:17:19 +0000 (11:17 +0200)]
Merge the new afs code.

14 years agoafh.h: Reduce AUDIO_FILE_INFO_SIZE.
Andre Noll [Sat, 8 Sep 2007 07:25:25 +0000 (09:25 +0200)]

As the audio file info string is going to be stored on disk, its size
starts to matter.

14 years agoipc.c: Improve para_semop().
Andre Noll [Sat, 8 Sep 2007 07:22:05 +0000 (09:22 +0200)]
ipc.c: Improve para_semop().

It's kind of silly to retry the semop 500 times. Just check if sempop()
was interrupted and retry in this case. Otherwise, error out.

14 years agoRename afs.[ch] to afs_common.[ch].
Andre Noll [Sat, 8 Sep 2007 07:14:27 +0000 (09:14 +0200)]
Rename afs.[ch] to afs_common.[ch].

As a prepraration for merging the new afs.

14 years agoaudiod: free pointer to config file path.
Andre Noll [Tue, 4 Sep 2007 20:21:16 +0000 (22:21 +0200)]
audiod: free pointer to config file path.

As it's no longer needed once the config file was parsed. Also, rename cf to

14 years agoaudiod: Fix a memory leak.
Andre Noll [Tue, 4 Sep 2007 20:16:06 +0000 (22:16 +0200)]
audiod: Fix a memory leak.

If the config file doesn't exist, configfile_exists() returnes NULL.
The old code leaked a pointer to the config file in this case.

This function is only called once at startup, so the leak is benign.
Morover, kill the static variable and the check if (!config_file) which
is always true.

14 years agoaudiod: Simplify two log messages.
Andre Noll [Tue, 4 Sep 2007 20:07:22 +0000 (22:07 +0200)]
audiod: Simplify two log messages.

Trivial cleanup.

14 years agonet.c: Improve documentation of struct crypt_data.
Andre Noll [Sun, 2 Sep 2007 15:12:11 +0000 (17:12 +0200)]
net.c: Improve documentation of struct crypt_data.

14 years agonet.c: Fix a fd leak in create_local_socket().
Andre Noll [Sun, 2 Sep 2007 14:57:15 +0000 (16:57 +0200)]
net.c: Fix a fd leak in create_local_socket().

The old code leaked the open socket fd in case of errors.

14 years agonet.c: Fix a typo in the documentation.
Andre Noll [Sun, 2 Sep 2007 14:52:33 +0000 (16:52 +0200)]
net.c: Fix a typo in the documentation.

14 years ago[TRIVIAL]: rename create_pf_socket() to create_local_socket().
Andre Noll [Sun, 2 Sep 2007 14:43:45 +0000 (16:43 +0200)]
[TRIVIAL]: rename create_pf_socket() to create_local_socket().

14 years agoFix some unsigned vs. size_t issues.
Andre Noll [Mon, 20 Aug 2007 17:51:18 +0000 (19:51 +0200)]
Fix some unsigned vs. size_t issues.

vss_het_header() took a unsigned while vss_get_chunk() takes
a size_t. Change vss_het_header() and fix up the callers.

15 years agofd.h: Kill two dead function prototypes.
Andre Noll [Mon, 13 Aug 2007 00:37:27 +0000 (02:37 +0200)]
fd.h: Kill two dead function prototypes.

15 years agoafh.h: Minor documentation improvements.
Andre Noll [Sun, 12 Aug 2007 23:34:03 +0000 (01:34 +0200)]
afh.h: Minor documentation improvements.

15 years agomysql_selector.c: Check return value of regcomp().
Andre Noll [Sun, 12 Aug 2007 23:03:43 +0000 (01:03 +0200)]
mysql_selector.c: Check return value of regcomp().

15 years agoNEWS update.
Andre Noll [Sun, 12 Aug 2007 22:49:37 +0000 (00:49 +0200)]
NEWS update.

15 years agodccp_send.c: Minor cleanups.
Andre Noll [Sun, 12 Aug 2007 22:10:23 +0000 (00:10 +0200)]
dccp_send.c: Minor cleanups.

Fix a missing newline and clarify docu of dccp_write().

15 years agodccp_send.c: Simplify send_queued_chunks().
Andre Noll [Sun, 12 Aug 2007 21:36:51 +0000 (23:36 +0200)]
dccp_send.c: Simplify send_queued_chunks().

The dccp socket is non-blocking, so there's no need to
check for writability.

15 years agodccp_send.c: Implement chunk queuing for dccp.
Andre Noll [Sun, 12 Aug 2007 21:26:27 +0000 (23:26 +0200)]
dccp_send.c: Implement chunk queuing for dccp.

As Gerrit mentioned, it might be a good idea to use chunk
queueing also for dccp. This patch uses the new cq_xxx()
abstractions in the same way as the http sender.

Not heavily tested yet.

15 years agoMove chunk_queue stuff to own files chunk_queue.[ch].
Andre Noll [Sun, 12 Aug 2007 17:44:33 +0000 (19:44 +0200)]
Move chunk_queue stuff to own files chunk_queue.[ch].

This completes the isolation of the chunk queueing code. In this form it may be
used also by other senders.

15 years agostruct http_client: Use a _pointer_ to the chunk_queue.
Andre Noll [Sun, 12 Aug 2007 16:47:50 +0000 (18:47 +0200)]
struct http_client: Use a _pointer_ to the chunk_queue.

This way, http_send.c no longer needs to know the size
of struct chunk_queue(). Allocation of the proper struct
is now done in cq_init().

15 years agoAbstract out chunk_queue code.
Andre Noll [Sun, 12 Aug 2007 16:36:53 +0000 (18:36 +0200)]
Abstract out chunk_queue code.

This moves the chunk handling code to separate functions cq_foo().  They
take pointers to a chunk queue, which makes them orthogonal to the rest of

15 years agoenqueue_chunk(): pass a struct chunk_queue * instead of struct http_client *.
Andre Noll [Sun, 12 Aug 2007 14:31:24 +0000 (16:31 +0200)]
enqueue_chunk(): pass a struct chunk_queue * instead of struct http_client *.

15 years agoIntroduce struct chunk_queue.
Andre Noll [Sun, 12 Aug 2007 14:27:03 +0000 (16:27 +0200)]
Introduce struct chunk_queue.

First step to abstract out chunk queueing.

15 years agoMerge branch 'chunk_queue' of /home/maan/scm/paraslash_meins/paraslash into tmp
Andre Noll [Sun, 12 Aug 2007 13:56:20 +0000 (15:56 +0200)]
Merge branch 'chunk_queue' of /home/maan/scm/paraslash_meins/paraslash into tmp

15 years agoortp_recv: Always set default jitter compensation, use zero as default.
Andre Noll [Sun, 12 Aug 2007 13:25:50 +0000 (15:25 +0200)]
ortp_recv: Always set default jitter compensation, use zero as default.

This makes the default configuration work again with

15 years agoRewrite chunk queueing.
Andre Noll [Wed, 8 Aug 2007 22:00:45 +0000 (00:00 +0200)]
Rewrite chunk queueing.

Since paraslash-0.2.16 the audio file is mmapped, so it is no longer neccessary
to make a copy of the chunk data in case a chunk can not be sent immediately
because the write would block. Just remember the chunk number and the number of
bytes of that chunk which were sent (non-zero in case of short writes).

The chunk data can then be retrieved by the new vss_get_chunk() function.

15 years agohttp_send.c: Trivial whitespace and spelling cleanups.
Andre Noll [Tue, 7 Aug 2007 21:13:05 +0000 (23:13 +0200)]
http_send.c: Trivial whitespace and spelling cleanups.

15 years agoDon't use depricated xxx_cmdline_parser_configfile().
Andre Noll [Mon, 6 Aug 2007 20:38:38 +0000 (22:38 +0200)]
Don't use depricated xxx_cmdline_parser_configfile().

Switch to the equivalent xxx_cmdline_parser_config_file() which takes
a pointer to the parser params.

15 years agoMerge /home/maan/scm/paraslash_fml/paraslash
Andre Noll [Mon, 6 Aug 2007 18:47:27 +0000 (20:47 +0200)]
Merge /home/maan/scm/paraslash_fml/paraslash

15 years agopara_malloc(), para_realloc(): Check for zero size allocations.
Andre Noll [Mon, 6 Aug 2007 18:45:19 +0000 (20:45 +0200)]
para_malloc(), para_realloc(): Check for zero size allocations.

15 years agodccp sender: Keep polling until an entry becomes free (Gerrit Renker).
Andre Noll [Mon, 6 Aug 2007 14:09:28 +0000 (16:09 +0200)]
dccp sender: Keep polling until an entry becomes free (Gerrit Renker).

If write() on the dccp fd fails with EAGAIN, the current code retries
100 times and then gives up, returning -E_DCCP_WRITE which causes a
shutdown of the dccp connection.

CCID3 has a sending wait queue which fills up and is emptied
asynchronously. The EAGAIN case means that there is currently no space
in the wait queue, but this can change at any moment and is thus not
an error condition. So keep polling until an entry becomes free.

15 years agoaudioc: fix bufsize
Andre Noll [Tue, 10 Jul 2007 20:11:58 +0000 (22:11 +0200)]
audioc: fix bufsize

This bug was introduced in ae0e4594c6a0312c5b4b4c0bde86f9c12253d11b:
We computed the bufsize from the conf struct before initializing it.
Fix is trivial.

15 years Add check for alarm().
Andre Noll [Sat, 7 Jul 2007 18:30:29 +0000 (20:30 +0200)] Add check for alarm().

15 years agoringbuffer.c: fix two typos.
Andre Noll [Sat, 7 Jul 2007 18:25:33 +0000 (20:25 +0200)]
ringbuffer.c: fix two typos.

15 years agotrivial doxygen cleanups
Andre Noll [Sat, 7 Jul 2007 18:21:48 +0000 (20:21 +0200)]
trivial doxygen cleanups

Replace @param by \param and fix punctuation.

15 years agomysql_selector: reset mysql_lock to zero after destroying the lock.
Andre Noll [Sat, 7 Jul 2007 18:07:20 +0000 (20:07 +0200)]
mysql_selector: reset mysql_lock to zero after destroying the lock.

15 years agoNEWS update
Andre Noll [Sat, 7 Jul 2007 17:30:08 +0000 (19:30 +0200)]
NEWS update

15 years agonet.h: add missing __printf_2_3 attribute to send_va_buffer()
Andre Noll [Sat, 7 Jul 2007 17:12:35 +0000 (19:12 +0200)]
net.h: add missing __printf_2_3 attribute to send_va_buffer()

15 years agomysql_selector.c: introduce the myslq lock
Andre Noll [Sat, 7 Jul 2007 17:11:45 +0000 (19:11 +0200)]
mysql_selector.c: introduce the myslq lock

This fixes a race condition in para_server:

parent child


This could cause para_server to hang in case the child process issued
a query which does not yield a result. It's hard to hit though. Fix is
to take the lock before the call to real_query, and release it after

The patch also fixes a format string bug which was introduced by the patch
that switched to my_ulonglong for suitable variables in mysql_selector.c.
These need "%lli".

15 years extend checks for header, functions, etc.
Andre Noll [Fri, 6 Jul 2007 09:15:39 +0000 (11:15 +0200)] extend checks for header, functions, etc.

One should really run autoscan from time to time...

15 years agodccp_send.c: Replace bzero() by memset()
Andre Noll [Fri, 6 Jul 2007 07:49:18 +0000 (09:49 +0200)]
dccp_send.c: Replace bzero() by memset()

bzero() is deprecated.

15 years agoortp_send.c: fix a gcc warning
Andre Noll [Wed, 4 Jul 2007 14:41:01 +0000 (16:41 +0200)]
ortp_send.c: fix a gcc warning

ortp_send.c:187: warning: passing argument 1 of 'vss_get_header' from incompatible pointer type

because vss_get_header expects an unsigned and we were passing a
size_t which is a different type e.g. for ppc.

15 years agoremove COPYING from the files to be converted by grutatxt
Andre Noll [Wed, 4 Jul 2007 12:42:32 +0000 (14:42 +0200)]
remove COPYING from the files to be converted by grutatxt

this is also not needed as html.

15 years agoremove GPL from the files to be converted by grutatxt
Andre Noll [Wed, 4 Jul 2007 12:33:08 +0000 (14:33 +0200)]
remove GPL from the files to be converted by grutatxt

The web page links directly to, no need to provide an html
version of this file.

15 years agoMerge /fml/ag-raetsch/home/maan/scm/paraslash_meins/paraslash
Andre Noll [Wed, 4 Jul 2007 12:20:14 +0000 (14:20 +0200)]
Merge /fml/ag-raetsch/home/maan/scm/paraslash_meins/paraslash

15 years agofix trivial typo
Andre Noll [Tue, 3 Jul 2007 18:35:26 +0000 (20:35 +0200)]
fix trivial typo

gengetopt already adds a ":" in the help output

15 years agomake gengetopt-2.20 happy
Andre Noll [Tue, 3 Jul 2007 18:32:50 +0000 (20:32 +0200)]
make gengetopt-2.20 happy

15 years agoweb/license.html: make it clear that paraslash is licensed under the GPL V2
Andre Noll [Sun, 1 Jul 2007 00:05:41 +0000 (02:05 +0200)]
web/license.html: make it clear that paraslash is licensed under the GPL V2

As today the GPL V3 was published, the term "GPL" (without mentioning
a version number) might be misleading.

15 years agoreplace standard GPL header by a one-line pointer to COPYING
Andre Noll [Thu, 28 Jun 2007 09:38:37 +0000 (11:38 +0200)]
replace standard GPL header by a one-line pointer to COPYING

15 years agoCOPYING: replace the short GPL text by the full version 2 license
Andre Noll [Mon, 25 Jun 2007 16:06:47 +0000 (18:06 +0200)]
COPYING: replace the short GPL text by the full version 2 license

15 years agotrivial typo fix
Andre Noll [Mon, 25 Jun 2007 15:58:47 +0000 (17:58 +0200)]
trivial typo fix

15 years agoMerge /fml/ag-raetsch/home/maan/scm/paraslash_meins/paraslash
Andre Noll [Mon, 11 Jun 2007 10:06:54 +0000 (12:06 +0200)]
Merge /fml/ag-raetsch/home/maan/scm/paraslash_meins/paraslash

15 years agoNEWS update
Andre Noll [Sun, 10 Jun 2007 23:53:59 +0000 (01:53 +0200)]
NEWS update

15 years agoclean up error.h
Andre Noll [Sun, 10 Jun 2007 23:45:51 +0000 (01:45 +0200)]
clean up error.h

It contained quite some unused error codes. This patch gets rid of
them and thus saves some space in the resulting binaries.

More importantly, there were two instances where a source file used
an error value of another source file (which is ok), but the object
file of that other source file would not get linked into the resulting
binary (which is not ok):

- aac_afh.c used E_AACDEC_INIT, which is not contained in

- http_recv.c used E_OVERRUN which is defined only if ortp
  support was compiled in.

The patch also fixes another bug in the ogg vorbis audio format handler
where (the positive value) E_STREAM_PAGEIN was returned instead of
-E_STREAM_PAGEIN in case ogg_stream_pagein() failed.

15 years agoogg_afh.c: add documentation of struct ogg_datasource
Andre Noll [Sun, 3 Jun 2007 21:58:44 +0000 (23:58 +0200)]
ogg_afh.c: add documentation of struct ogg_datasource

15 years agoallow variable arguments in LOG functions to be omitted or empty.
Andre Noll [Sun, 3 Jun 2007 19:45:20 +0000 (21:45 +0200)]
allow variable arguments in LOG functions to be omitted or empty.

If the variable arguments are omitted or empty, the '##' operator
causes the preprocessor to remove the comma before it.

15 years agodccp_send.c: Fix type of "header_len" on x86_64
Andre Noll [Fri, 1 Jun 2007 09:53:11 +0000 (11:53 +0200)]
dccp_send.c: Fix type of "header_len" on x86_64

vss_get_header wants an unsigned, not a size_t. Fixes

dccp_send.c:170: warning: passing arg 1 of `vss_get_header' from incompatible pointer type

15 years agoTrivial %d -> %zu format string fix
Andre Noll [Fri, 1 Jun 2007 09:50:02 +0000 (11:50 +0200)]
Trivial %d -> %zu format string fix

It fixes

command.c:879: warning: int format, different type arg (arg 4)

15 years agofade: cosmetic cleanups
Andre Noll [Sat, 26 May 2007 21:02:18 +0000 (23:02 +0200)]
fade: cosmetic cleanups

always return negative values on errors, some other trivial changes.

15 years agofade.c: simplify open_mixer()
Andre Noll [Sat, 26 May 2007 20:47:48 +0000 (22:47 +0200)]
fade.c: simplify open_mixer()

open() returns -1 on errors anyway.

15 years agofade.c: replace args_info by conf
Andre Noll [Sat, 26 May 2007 20:43:15 +0000 (22:43 +0200)]
fade.c: replace args_info by conf

to be consistent with the other paraslash applications that also use
conf for the gengetopt args_info struct.

15 years agofade.c: Fix some signed issues
Andre Noll [Sat, 26 May 2007 20:39:23 +0000 (22:39 +0200)]
fade.c: Fix some signed issues

Don't sleep at all if the sleep time passed via comamnd line args
are negative.

15 years agofix some signed warnings in aac and mp3 decoders
Andre Noll [Sat, 26 May 2007 20:25:44 +0000 (22:25 +0200)]
fix some signed warnings in aac and mp3 decoders

Only trivial stuff.

15 years agobe more carful wrt. signed vs. unsigned argument passing
Andre Noll [Sat, 26 May 2007 19:38:36 +0000 (21:38 +0200)]
be more carful wrt. signed vs. unsigned argument passing

15 years agoerror.h: move E_BAD_USER from audiod_command to command error list
Andre Noll [Mon, 21 May 2007 20:53:23 +0000 (22:53 +0200)]
error.h: move E_BAD_USER from audiod_command to command error list

Dooh. This caused a segfault in the server's child if an unkown user
connected. Fortunately, this happened right before the process exited
anyway, so it's not a security issue.

15 years agoadd -Wbad-function-cast to +CPPFLAGS and fix two compiler warnings
Andre Noll [Sat, 19 May 2007 11:19:27 +0000 (13:19 +0200)]
add -Wbad-function-cast to +CPPFLAGS and fix two compiler warnings

15 years agoaac: fix some signedness warnings
Andre Noll [Sat, 19 May 2007 09:34:16 +0000 (11:34 +0200)]
aac: fix some signedness warnings