return 1;
}
-/**
- * Resolve IPv4/IPv6 address and create a ready-to-use active or passive socket.
+/*
+ * Create an active or passive socket.
*
- * \param l4type The layer-4 type (\p IPPROTO_xxx).
- * \param passive Whether this is a passive or active socket.
- * \param host Passed to \ref \a lookup_address().
- * \param port_number Passed to \ref \a lookup_address().
+ * \param l4type \p IPPROTO_TCP, \p IPPROTO_UDP, or \p IPPROTO_DCCP.
+ * \param passive Whether to call bind(2) or connect(2).
+ * \param ai Address information as obtained from \ref lookup_address().
* \param fo Socket options to be set before making the connection.
*
- * This creates a ready-made IPv4/v6 socket structure after looking up the
- * necessary parameters.
- *
* bind(2) is called on passive sockets, and connect(2) on active sockets. The
* algorithm tries all possible address combinations until it succeeds. If \a
* fo is supplied, options are set and cleanup is performed.
*
- * \return Standard.
+ * \return File descriptor on success, \p E_MAKESOCK on errors.
*
- * \sa \ref lookup_address(), ipv6(7), getaddrinfo(3), bind(2), connect(2).
+ * \sa \ref lookup_address(), \ref makesock(), ip(7), ipv6(7), bind(2),
+ * connect(2).
*/
-int makesock(unsigned l4type, bool passive,
- const char *host, uint16_t port_number,
- struct flowopts *fo)
+static int makesock_addrinfo(unsigned l4type, bool passive, struct addrinfo *ai,
+ struct flowopts *fo)
{
- struct addrinfo *local = NULL, *src = NULL, *remote = NULL, *dst = NULL;
- int rc, on = 1, sockfd = -1;
+ struct addrinfo *local, *remote, *src = NULL, *dst = NULL;
+ int ret = -E_MAKESOCK, on = 1, sockfd = -1;
+
+ if (passive) {
+ local = ai;
+ remote = NULL;
+ } else {
+ local = NULL;
+ remote = ai;
+ }
- rc = lookup_address(l4type, passive, host, port_number, passive?
- &local : &remote);
- if (rc < 0)
- goto out;
/* Iterate over all src/dst combination, exhausting dst first */
for (src = local, dst = remote; src != NULL || dst != NULL; /* no op */ ) {
if (src && dst && src->ai_family == AF_INET
&& dst->ai_family == AF_INET6)
goto get_next_dst; /* v4 -> v6 is not possible */
- sockfd = socket(src ? src->ai_family : dst->ai_family,
+ ret = socket(src ? src->ai_family : dst->ai_family,
sock_type(l4type), l4type);
- if (sockfd < 0)
+ if (ret < 0)
goto get_next_dst;
-
+ sockfd = ret;
/*
* Reuse the address on passive sockets to avoid failure on
* restart (protocols using listen()) and when creating
*/
if (passive && setsockopt(sockfd, SOL_SOCKET, SO_REUSEADDR,
&on, sizeof(on)) == -1) {
- rc = errno;
+ ret = -ERRNO_TO_PARA_ERROR(errno);
close(sockfd);
PARA_ERROR_LOG("can not set SO_REUSEADDR: %s\n",
- strerror(rc));
- rc = -ERRNO_TO_PARA_ERROR(rc);
+ para_strerror(-ret));
break;
}
flowopt_setopts(sockfd, fo);
if (src && (src = src->ai_next)) /* restart inner loop */
dst = remote;
}
-out:
- if (local)
- freeaddrinfo(local);
- if (remote)
- freeaddrinfo(remote);
- flowopt_cleanup(fo);
+ if (src == NULL && dst == NULL)
+ return ret < 0? ret : -E_MAKESOCK;
+ return sockfd;
+}
- if (src == NULL && dst == NULL) {
- if (rc >= 0)
- rc = -E_MAKESOCK;
+/**
+ * Resolve IPv4/IPv6 address and create a ready-to-use active or passive socket.
+ *
+ * \param l4type The layer-4 type (\p IPPROTO_xxx).
+ * \param passive Whether this is a passive or active socket.
+ * \param host Passed to \ref lookup_address().
+ * \param port_number Passed to \ref lookup_address().
+ * \param fo Passed to \ref makesock_addrinfo().
+ *
+ * This creates a ready-made IPv4/v6 socket structure after looking up the
+ * necessary parameters. The function first calls \ref lookup_address() and
+ * passes the address information to makesock_addrinfo() to create and
+ * initialize the socket.
+ *
+ * \return The newly created file descriptor on success, a negative error code
+ * on failure.
+ *
+ * \sa \ref lookup_address(), \ref makesock_addrinfo().
+ */
+int makesock(unsigned l4type, bool passive, const char *host, uint16_t port_number,
+ struct flowopts *fo)
+{
+ struct addrinfo *ai;
+ int ret = lookup_address(l4type, passive, host, port_number, &ai);
+
+ if (ret >= 0)
+ ret = makesock_addrinfo(l4type, passive, ai, fo);
+ if (ai)
+ freeaddrinfo(ai);
+ flowopt_cleanup(fo);
+ if (ret < 0) {
PARA_ERROR_LOG("can not create %s socket %s#%d.\n",
- layer4_name(l4type), host? host : (passive?
- "[loopback]" : "[localhost]"), port_number);
- return rc;
+ layer4_name(l4type), host? host : (passive?
+ "[loopback]" : "[localhost]"), port_number);
}
- return sockfd;
+ return ret;
}
/**