static void dccp_post_select(fd_set *rfds, __a_unused fd_set *wfds)
{
struct dccp_client *dc;
- int ret;
+ int ret, fd;
- if (!FD_ISSET(listen_fd, rfds))
+ if (listen_fd < 0 || !FD_ISSET(listen_fd, rfds))
return;
ret = para_accept(listen_fd, NULL, 0);
if (ret < 0) {
PARA_ERROR_LOG("%s\n", para_strerror(-ret));
return;
}
+ fd = ret;
/*
* Bypass unused CCID paths: the sender does not receive application data
* from the client; by shutting down this unused communication path we can
* reduce processing costs a bit. See analogous comment in dccp_recv.c.
*/
- if (shutdown(ret, SHUT_RD) < 0) {
+ if (shutdown(fd, SHUT_RD) < 0) {
PARA_ERROR_LOG("shutdown(SHUT_RD): %s\n", strerror(errno));
- return;
+ goto err;
}
dc = para_calloc(sizeof(struct dccp_client));
dc->fd = ret;
add_close_on_fork_list(dc->fd);
mark_fd_nonblocking(dc->fd);
dc->cq = cq_new(DCCP_MAX_PENDING_BYTES);
+ return;
+err:
+ close(fd);
}
static int dccp_open(void)
if (ret < 0)
return ret;
listen_fd = ret;
+ ret = mark_fd_nonblocking(listen_fd);
+ if (ret < 0) {
+ PARA_EMERG_LOG("%s\n", para_strerror(-ret));
+ exit(EXIT_FAILURE);
+ }
add_close_on_fork_list(listen_fd);
- mark_fd_nonblocking(listen_fd);
return 1;
}
s->client_cmds[SENDER_DELETE] = NULL;
self = s;
ret = dccp_open();
- if (ret < 0) {
+ if (ret < 0)
PARA_ERROR_LOG("%s\n", para_strerror(-ret));
- s->status = SENDER_OFF;
- } else
- s->status = SENDER_ON;
}