sched: Dont use fixed-size buffer for task names.

[paraslash.git] / sched.c

diff --git a/sched.c b/sched.c
index cad298b839b83a3f28e70912b1c85201ed589bd5..0a1cff28521dfe12c8f75316b1a1ce35206c1918 100644 (file)
--- a/sched.c
+++ b/sched.c
@@ -19,16 +19,16 @@
 #include "error.h"
 
 struct task {
+       /** The task name supplied when the task was registered(). */
+       char *name;
        /** Copied from the task_info struct during task_register(). */
        void (*pre_select)(struct sched *s, struct task *t);
        /** Copied from the task_info struct during task_register(). */
        int (*post_select)(struct sched *s, struct task *t);
        /** Whether this task is active (>=0) or in error state (<0). */
-       int error;
+       int status;
        /** Position of the task in the task list of the scheduler. */
        struct list_head node;
-       /** The task name supplied when the task was registered(). */
-       char status[255];
        /** If less than zero, the task was notified by another task. */
        int notification;
        /** True if task is in error state and exit status has been queried. */
@@ -51,7 +51,7 @@ static void sched_preselect(struct sched *s)
        struct task *t, *tmp;
 
        list_for_each_entry_safe(t, tmp, &s->task_list, node) {
-               if (t->error < 0)
+               if (t->status < 0)
                        continue;
                if (t->notification != 0)
                        sched_min_delay(s);
@@ -62,8 +62,9 @@ static void sched_preselect(struct sched *s)
 
 static void unlink_and_free_task(struct task *t)
 {
-       PARA_INFO_LOG("freeing task %s\n", t->status);
+       PARA_INFO_LOG("freeing task %s\n", t->name);
        list_del(&t->node);
+       free(t->name);
        free(t);
 }
 
@@ -71,19 +72,19 @@ static void unlink_and_free_task(struct task *t)
 static inline void call_post_select(struct sched *s, struct task *t)
 {
 #ifndef SCHED_DEBUG
-       t->error = t->post_select(s, t);
+       t->status = t->post_select(s, t);
 #else
        struct timeval t1, t2, diff;
        unsigned long pst;
 
        clock_get_realtime(&t1);
-       t->error = t->post_select(s, t);
+       t->status = t->post_select(s, t);
        clock_get_realtime(&t2);
        tv_diff(&t1, &t2, &diff);
        pst = tv2ms(&diff);
        if (pst > 50)
                PARA_WARNING_LOG("%s: post_select time: %lums\n",
-                       t->status, pst);
+                       t->name, pst);
 #endif
 }
 
@@ -93,14 +94,14 @@ static unsigned sched_post_select(struct sched *s)
        unsigned num_running_tasks = 0;
 
        list_for_each_entry_safe(t, tmp, &s->task_list, node) {
-               if (t->error < 0) {
+               if (t->status < 0) {
                        if (t->dead) /* task has been reaped */
                                unlink_and_free_task(t);
                        continue;
                }
                call_post_select(s, t);
                t->notification = 0;
-               if (t->error >= 0)
+               if (t->status >= 0)
                        num_running_tasks++;
        }
        return num_running_tasks;
@@ -184,7 +185,7 @@ int task_reap(struct task **tptr)
        t = *tptr;
        if (!t)
                return 0;
-       if (t->error >= 0)
+       if (t->status >= 0)
                return 0;
        if (t->dead) /* will be freed in sched_post_select() */
                return 0;
@@ -198,7 +199,7 @@ int task_reap(struct task **tptr)
         */
        t->dead = true;
        *tptr = NULL;
-       return t->error;
+       return t->status;
 }
 
 /**
@@ -213,10 +214,10 @@ void sched_shutdown(struct sched *s)
        struct task *t, *tmp;
 
        list_for_each_entry_safe(t, tmp, &s->task_list, node) {
-               if (t->error >= 0)
+               if (t->status >= 0)
                        /* The task list should contain only terminated tasks. */
                        PARA_WARNING_LOG("shutting down running task %s\n",
-                               t->status);
+                               t->name);
                unlink_and_free_task(t);
        }
 }
@@ -239,10 +240,9 @@ struct task *task_register(struct task_info *info, struct sched *s)
        if (!s->task_list.next)
                INIT_LIST_HEAD(&s->task_list);
 
-       snprintf(t->status, sizeof(t->status) - 1, "%s", info->name);
-       t->status[sizeof(t->status) - 1] = '\0';
+       t->name = para_strdup(info->name);
        t->notification = 0;
-       t->error = 0;
+       t->status = 0;
        t->dead = false;
        t->pre_select = info->pre_select;
        t->post_select = info->post_select;
@@ -282,8 +282,8 @@ char *get_task_list(struct sched *s)
        list_for_each_entry_safe(t, tmp, &s->task_list, node) {
                char *tmp_msg;
                tmp_msg = make_message("%s%p\t%s\t%s\n", msg? msg : "", t,
-                       t->error < 0? (t->dead? "dead" : "zombie") : "running",
-                       t->status);
+                       t->status < 0? (t->dead? "dead" : "zombie") : "running",
+                       t->name);
                free(msg);
                msg = tmp_msg;
        }
@@ -314,7 +314,7 @@ void task_notify(struct task *t, int err)
        assert(err > 0);
        if (t->notification == -err) /* ignore subsequent notifications */
                return;
-       PARA_INFO_LOG("notifying task %s: %s\n", t->status, para_strerror(err));
+       PARA_INFO_LOG("notifying task %s: %s\n", t->name, para_strerror(err));
        t->notification = -err;
 }
 
@@ -348,9 +348,9 @@ int task_status(const struct task *t)
                return 0;
        if (t->dead)
                return 0;
-       if (t->error >= 0)
+       if (t->status >= 0)
                return 1;
-       return t->error;
+       return t->status;
 }
 
 /**