simplify lookup_user()

[paraslash.git] / user_list.c

diff --git a/user_list.c b/user_list.c
index 75dca081c7685a112e29fbc79f98d5ae0a475c34..c6d45ca5f4b2846f7f5a6350a8e84b3c551539a7 100644 (file)
--- a/user_list.c
+++ b/user_list.c
@@ -79,7 +79,7 @@ static void populate_user_list(char *user_list_file)
                        else if (!strcmp(tmp[num], "DB_WRITE"))
                                u->perms |= DB_WRITE;
                        else /* unknown permission */
-                               PARA_WARNING_LOG("unknown permission: %s\n",
+                               PARA_WARNING_LOG("ignoring unknown permission: %s\n",
                                        tmp[num]);
                }
                para_list_add(&u->node, &user_list);
@@ -93,6 +93,14 @@ out:
        exit(EXIT_FAILURE);
 }
 
+/**
+ * initialize the list of users allowed to connecto to para_server
+ *
+ * \param user_list_file the file containing access information
+ *
+ * If this function is called a second time, the contents of the
+ * previous call are discarded.
+ */
 void init_user_list(char *user_list_file)
 {
        struct user *u, *tmp;
@@ -114,19 +122,18 @@ void init_user_list(char *user_list_file)
 /**
  * lookup user in user_list.
  *
- * \param user: must initially contain the name of the user and is filled
- * in by this function on success.
+ * \param name of the user
  *
- * \return 1 on success and < 0 on errors.
+ * \return a pointer to the corresponding user struct if the user was found,
+ *  \p NULL otherwise.
  */
-int lookup_user(struct user *user)
+struct user *lookup_user(const char *name)
 {
        struct user *u;
        list_for_each_entry(u, &user_list, node) {
-               if (strcmp(u->name, user->name))
+               if (strcmp(u->name, name))
                        continue;
-               *user = *u;
-               return 1;
+               return u;
        }
-       return -E_BAD_USER;
+       return NULL;
 }