/*
- * Copyright (C) 2006-2007 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2006-2008 Andre Noll <maan@systemlinux.org>
*
* Licensed under the GPL v2. For licencing details see COPYING.
*/
static void wng_pre_select(__a_unused struct sched *s, struct task *t)
{
- struct writer_node_group *g = t->private_data;
+ struct writer_node_group *g = container_of(t, struct writer_node_group, task);
int i;
FOR_EACH_WRITER_NODE(i, g) {
struct writer_node *wn = &g->writer_nodes[i];
- t->ret = wn->writer->pre_select(s, wn);
- if (t->ret < 0) {
- g->eof = 1;
+ t->error = wn->writer->pre_select(s, wn);
+ if (t->error < 0)
return;
- }
}
}
static void wng_post_select(struct sched *s, struct task *t)
{
- struct writer_node_group *g = t->private_data;
+ struct writer_node_group *g = container_of(t, struct writer_node_group, task);
int i;
size_t min_written = 0;
FOR_EACH_WRITER_NODE(i, g) {
struct writer_node *wn = &g->writer_nodes[i];
- t->ret = wn->writer->post_select(s, wn);
- if (t->ret < 0) {
- g->eof = 1;
+ t->error = wn->writer->post_select(s, wn);
+ if (t->error < 0)
return;
- }
if (!i)
min_written = wn->written;
else
min_written = PARA_MIN(min_written, wn->written);
}
-// PARA_INFO_LOG("loaded: %zd, min_written: %zd bytes\n", *g->loaded, min_written);
+ //PARA_INFO_LOG("loaded: %zd, min_written: %zd bytes\n", *g->loaded, min_written);
if (min_written) {
*g->loaded -= min_written;
FOR_EACH_WRITER_NODE(i, g)
g->writer_nodes[i].written -= min_written;
}
- if (!*g->loaded && *g->input_eof) {
- g->eof = 1;
- t->ret = -E_WNG_EOF;
+ if (!*g->loaded && *g->input_error) {
+ t->error = *g->input_error;
return;
}
- t->ret = 1;
if (*g->loaded && min_written) {
// PARA_INFO_LOG("moving %zd bytes\n", *g->loaded);
memmove(g->buf, g->buf + min_written, *g->loaded);
* \return If at least one open function returned an error, all successful
* writer notes get closed and this error value is returned. Upon success, a
* task associated with \a g is registered to the scheduler and the function
- * returnes a positive value.
+ * returns a positive value.
* */
int wng_open(struct writer_node_group *g)
{
int i, ret = 1;
PARA_NOTICE_LOG("opening wng %p with %d writer(s)\n", g, g->num_writers);
- register_task(&g->task);
FOR_EACH_WRITER_NODE(i, g) {
struct writer_node *wn = &g->writer_nodes[i];
wn->wng = g;
g->max_chunk_bytes = PARA_MAX(g->max_chunk_bytes, ret);
}
sprintf(g->task.status, "%s", "writer node group");
- g->eof = 0;
+ register_task(&g->task);
+ g->open = 1;
return 1;
err_out:
- PARA_ERROR_LOG("%s\n", PARA_STRERROR(-ret));
- unregister_task(&g->task);
+ PARA_ERROR_LOG("%s\n", para_strerror(-ret));
while (i > 0) {
struct writer_node *wn = &g->writer_nodes[--i];
wn->writer->close(wn);
}
g->num_writers = 0;
- g->eof = 1;
return ret;
}
-
-/**
- * unregister a writer node group task
- *
- * \param g the group whose task is to be closed
- */
-void wng_unregister(struct writer_node_group *g)
-{
- unregister_task(&g->task);
- g->eof = 1;
-}
-
/**
* call the close function of each writer in the given group
*
{
int i;
- if (!g)
+ if (!g || !g->open)
return;
PARA_NOTICE_LOG("closing wng with %d writer(s)\n", g->num_writers);
FOR_EACH_WRITER_NODE(i, g) {
g->num_writers = num_writers;
g->writer_nodes = para_calloc(num_writers
* sizeof(struct writer_node));
- g->task.private_data = g;
g->task.post_select = wng_post_select;
g->task.pre_select = wng_pre_select;
return g;
* \param writer_num contains the number of the writer upon success
*
* This function checks whether \a wa starts with the name of a supported
- * paraslash writer, optinally followed by a colon and any options for that
+ * paraslash writer, optionally followed by a colon and any options for that
* writer. If a valid writer name was found and further are present, the
* remaining part of \a wa is passed to that writer's config parser.
*
*writer_num = i;
return writers[i].parse_config(c? wa + len + 1 : "");
}
- PARA_ERROR_LOG("%s", "writer not found\n");
+ PARA_ERROR_LOG("writer not found\n");
return NULL;
}