summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
5e9ded6)
Currently if get_afsi_of_row() fails, we add the file to the score
list anyway. This function should never fail, and if it does, we are
in serious trouble anyway and should return the proper error code
rather than success.
statistics.last_played_sum, statistics.last_played_qd);
}
statistics.last_played_sum, statistics.last_played_qd);
}
-static long compute_dynamic_score(const struct osl_row *aft_row)
+static long compute_dynamic_score(struct afs_info *afsi)
- struct afs_info afsi;
-
- if (get_afsi_of_row(aft_row, &afsi) < 0)
- return -100;
- return compute_num_played_score(&afsi) + compute_last_played_score(&afsi);
+ return compute_num_played_score(afsi) + compute_last_played_score(afsi);
}
static int add_afs_statistics(const struct osl_row *row)
}
static int add_afs_statistics(const struct osl_row *row)
static int add_to_score_table(const struct osl_row *aft_row, long mood_score)
{
static int add_to_score_table(const struct osl_row *aft_row, long mood_score)
{
- long score = (compute_dynamic_score(aft_row) + mood_score) / 3;
+ long score;
+ struct afs_info afsi;
+ int ret = get_afsi_of_row(aft_row, &afsi);
+
+ if (ret < 0)
+ return ret;
+ score = (compute_dynamic_score(&afsi) + mood_score) / 3;
return score_add(aft_row, score);
}
return score_add(aft_row, score);
}