net: Always initialize struct sockaddr_storage.

The static analyzer of clang claims that the left operand of the condition

	ss->ss_family == AF_INET6 && IN6_IS_ADDR_V4MAPPED(&ia6->sin6_addr);

in SS_IS_ADDR_V4MAPPED() is a garbage value. The code has been like
this for seven years without problems, so the warning is probably
bogus.

It does not hurt to initialize the sockaddr_storage structures though,
which silences the warning.

diff --git a/net.c b/net.c
index fa7cd4b80a7d96b26e35add01ad97d9a123f138d..eaa1cfb81146b3dc4fd7bb11cd41df447dc0e825 100644 (file)
--- a/net.c
+++ b/net.c
@@ -603,7 +603,7 @@ static inline int estimated_header_overhead(const int af_type)
  */
 int generic_max_transport_msg_size(int sockfd)
 {
  */
 int generic_max_transport_msg_size(int sockfd)
 {

-       struct sockaddr_storage ss;
+       struct sockaddr_storage ss = {0};

        socklen_t sslen = sizeof(ss);
        int af_type = AF_INET;
 
        socklen_t sslen = sizeof(ss);
        int af_type = AF_INET;
 


@@ -629,7 +629,7 @@ int generic_max_transport_msg_size(int sockfd)
  */
 char *remote_name(int fd)
 {
  */
 char *remote_name(int fd)
 {

-       struct sockaddr_storage ss;
+       struct sockaddr_storage ss = {0};

        const struct sockaddr *sa;
        socklen_t sslen = sizeof(ss);
        char hbuf[NI_MAXHOST], sbuf[NI_MAXSERV];
        const struct sockaddr *sa;
        socklen_t sslen = sizeof(ss);
        char hbuf[NI_MAXHOST], sbuf[NI_MAXSERV];