]> git.tuebingen.mpg.de Git - paraslash.git/commitdiff
client: Fix memory leak on exit. master
authorAndre Noll <maan@tuebingen.mpg.de>
Thu, 21 Mar 2024 11:39:06 +0000 (12:39 +0100)
committerAndre Noll <maan@tuebingen.mpg.de>
Tue, 7 May 2024 18:29:02 +0000 (20:29 +0200)
This triggers only if para_client is run interactively. The leak is
harmless, but still..

NEWS.md
client.c
ipc.c

diff --git a/NEWS.md b/NEWS.md
index 4b718d8a6b396ee143fd7de65d9b49f32f0f0dd4..d5812289640d71c52a60bd850928c72b3c5ba0b8 100644 (file)
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,9 +1,24 @@
 NEWS
 ====
 
-----------------------------------------------
-0.7.3 (to be announced) "weighted correctness"
-----------------------------------------------
+---------------------------------------------
+0.7.4 (to be announced) "genetic contraction"
+---------------------------------------------
+
+Downloads:
+[tarball](./releases/paraslash-git.tar.xz)
+
+-----------------------------------------
+0.7.3 (2024-03-12) "weighted correctness"
+-----------------------------------------
+
+The highlight of this release is the new "ls --admissible=m/foo"
+feature described below. Other user-visible changes include minor
+additions to the "ls" and "select" server commands. The release also
+includes a fair number of cleanups for the crypto code and the file
+descriptor utilities, both without visible effects. Old ssh keys
+and outdated openssl library versions are now deprecated and cause
+warnings.
 
 - Old style PEM keys are now deprecated. They still work but their
   use results in a run-time warning. The removal of PEM key support is
@@ -23,7 +38,8 @@ NEWS
 - Cleanup of the openssl-specific code.
 
 Downloads:
-[tarball](./releases/paraslash-git.tar.xz)
+[tarball](./releases/paraslash-0.7.3.tar.xz),
+[signature](./releases/paraslash-0.7.3.tar.xz.asc)
 
 -------------------------------------
 0.7.2 (2023-03-08) "optical friction"
index 84b7580cf9554c433651da1f3eed28a6f1f39a74..d2d11fd34344d5b4f5186daf568850fe153cbacb 100644 (file)
--- a/client.c
+++ b/client.c
@@ -549,6 +549,7 @@ __noreturn static void interactive_session(void)
        i9e_close();
        para_log = stderr_log;
 out:
+       free(ici.history_file);
        if (ret < 0)
                PARA_ERROR_LOG("%s\n", para_strerror(-ret));
        exit(ret < 0? EXIT_FAILURE : EXIT_SUCCESS);
diff --git a/ipc.c b/ipc.c
index 8e9dd51a2369e7e60ebd4bda3fa889eaed892248..c245f690788630e19f2c7e82bda903360e1c0fa5 100644 (file)
--- a/ipc.c
+++ b/ipc.c
@@ -218,7 +218,7 @@ size_t shm_get_shmmax(void)
        {
                int fd = open("/proc/sys/kernel/shmmax", O_RDONLY);
                if (fd >= 0) {
-                       char buf[100] = "";
+                       char buf[100];
                        int ret = read(fd, buf, sizeof(buf) - 1);
                        if (ret > 0) {
                                buf[ret] = '\0';