]> git.tuebingen.mpg.de Git - paraslash.git/commitdiff
alsa: Don't set t->error in ->pre_select().
authorAndre Noll <maan@systemlinux.org>
Thu, 13 Jun 2013 08:54:24 +0000 (10:54 +0200)
committerAndre Noll <maan@systemlinux.org>
Sat, 8 Mar 2014 13:39:33 +0000 (14:39 +0100)
->pre_select() methods should never fail, and tasks should not
set this variable at all. It is ignored anyway when set there.

alsa_write.c

index a3912c1165e6054b0be0bd622b17175fdad4fd8a..0824640b9560d72a1eb886a355c3f07e5271681f 100644 (file)
@@ -211,7 +211,6 @@ static void alsa_write_pre_select(struct sched *s, struct task *t)
        if (ret < 0) {
                PARA_ERROR_LOG("could not get alsa poll fd: %s\n",
                        snd_strerror(-ret));
        if (ret < 0) {
                PARA_ERROR_LOG("could not get alsa poll fd: %s\n",
                        snd_strerror(-ret));
-               t->error = -E_ALSA;
                return;
        }
        pad->poll_fd = pfd.fd;
                return;
        }
        pad->poll_fd = pfd.fd;