gui: Check return value of para_exec_cmdline_pid().

external_cmd() calls this function to execute the given command.
However, as para_exec_cmdline_pid() may fail, e.g. because the
underlying call to fork() failed due to hitting the RLIMIT_NPROC
resource limit, we must check the return value. The other two command
dispatchers got this right, but external_cmd() did not.

diff --git a/gui.c b/gui.c
index 48d4b51b6445c902a791755cc84737f3421dafc7..2ed66be7b2f4efaec7ebf4dacc6f72039a529daa 100644 (file)
--- a/gui.c
+++ b/gui.c
@@ -1112,7 +1112,8 @@ static void external_cmd(char *cmd)
        if (cmd_pid)
                return;
        shutdown_curses();
        if (cmd_pid)
                return;
        shutdown_curses();

-       para_exec_cmdline_pid(&cmd_pid, cmd, fds);
+       if (para_exec_cmdline_pid(&cmd_pid, cmd, fds) < 0)
+               return;

        cmd_died = 0;
        do_select(EXTERNAL_MODE);
        init_curses();
        cmd_died = 0;
        do_select(EXTERNAL_MODE);
        init_curses();