- Avoid use of global current_mood pointer where possible.
- Change name of non-static functions that use the current mood pointer:
mood_open() -> change_current_mood()
mood_close() -> close_current_mood()
mood_reload() -> reload_current_mood()
given_playlist = "given_playlist";
if (given_mood) {
given_playlist = "given_playlist";
if (given_mood) {
- ret = mood_open(given_mood);
+ ret = change_current_mood(given_mood);
if (ret >= 0) {
if (given_playlist)
PARA_WARNING_LOG("ignoring playlist %s\n",
if (ret >= 0) {
if (given_playlist)
PARA_WARNING_LOG("ignoring playlist %s\n",
if (ret >= 0)
return PLAY_MODE_PLAYLIST;
}
if (ret >= 0)
return PLAY_MODE_PLAYLIST;
}
- ret = mood_open(NULL); /* open first available mood */
+ ret = change_current_mood(NULL); /* open first available mood */
if (ret >= 0)
return PLAY_MODE_MOOD;
if (ret >= 0)
return PLAY_MODE_MOOD;
- mood_open(""); /* open dummy mood, always successful */
+ change_current_mood(""); /* open dummy mood, always successful */
PARA_NOTICE_LOG("closing afs_tables\n");
score_shutdown(flags);
attribute_shutdown(flags);
PARA_NOTICE_LOG("closing afs_tables\n");
score_shutdown(flags);
attribute_shutdown(flags);
playlist_close();
moods_shutdown(flags);
playlists_shutdown(flags);
playlist_close();
moods_shutdown(flags);
playlists_shutdown(flags);
int aft_check_callback(const struct osl_object *query, struct osl_object *result);
/* mood */
int aft_check_callback(const struct osl_object *query, struct osl_object *result);
/* mood */
-int mood_open(char *mood_name);
-void mood_close(void);
+int change_current_mood(char *mood_name);
+void close_current_mood(void);
int mood_update_audio_file(const struct osl_row *aft_row, struct afs_info *old_afsi);
int mood_update_audio_file(const struct osl_row *aft_row, struct afs_info *old_afsi);
+int reload_current_mood(void);
int mood_delete_audio_file(const struct osl_row *aft_row);
int mood_delete_audio_file(const struct osl_row *aft_row);
if (ret < 0)
return ret;
find_greatest_att_bitnum();
if (ret < 0)
return ret;
find_greatest_att_bitnum();
- return mood_reload(); /* FIXME: mood_reload() returns an error */
+ return reload_current_mood(); /* FIXME: mood_reload() returns an error */
}
int com_addatt(__a_unused int fd, int argc, char * const * const argv)
}
int com_addatt(__a_unused int fd, int argc, char * const * const argv)
find_greatest_att_bitnum();
if (!atts_removed)
return 1;
find_greatest_att_bitnum();
if (!atts_removed)
return 1;
- return mood_reload(); /* FIXME: Fix mood_reload() */
+ return reload_current_mood();
}
int com_rmatt(__a_unused int fd, int argc, char * const * const argv)
}
int com_rmatt(__a_unused int fd, int argc, char * const * const argv)
* \sa mood_item, mood_open().
*/
struct mood {
* \sa mood_item, mood_open().
*/
struct mood {
- /** the name of this mood */
+ /** The name of this mood. */
char *name;
/** The list of mood items of type \p accept. */
struct list_head accept_list;
char *name;
/** The list of mood items of type \p accept. */
struct list_head accept_list;
-static int load_mood(const struct osl_row *row)
+static int load_mood(const struct osl_row *mood_row, struct mood **m)
- struct mood *new_mood, *old_mood = current_mood;
struct osl_object objs[NUM_BLOB_COLUMNS];
struct osl_object objs[NUM_BLOB_COLUMNS];
- ret = osl_get_object(moods_table, row, BLOBCOL_NAME, &objs[BLOBCOL_NAME]);
+ ret = osl_get_object(moods_table, mood_row, BLOBCOL_NAME, &objs[BLOBCOL_NAME]);
if (ret < 0)
return ret;
if (objs[BLOBCOL_NAME].size <= 1)
return -E_DUMMY_ROW;
if (ret < 0)
return ret;
if (objs[BLOBCOL_NAME].size <= 1)
return -E_DUMMY_ROW;
- ret = osl_open_disk_object(moods_table, row, BLOBCOL_DEF, &objs[BLOBCOL_DEF]);
+ ret = osl_open_disk_object(moods_table, mood_row, BLOBCOL_DEF, &objs[BLOBCOL_DEF]);
- new_mood = alloc_new_mood((char*)objs[BLOBCOL_NAME].data);
- current_mood = new_mood;
+ *m = alloc_new_mood((char*)objs[BLOBCOL_NAME].data);
ret = for_each_line_ro(objs[BLOBCOL_DEF].data, objs[BLOBCOL_DEF].size,
ret = for_each_line_ro(objs[BLOBCOL_DEF].data, objs[BLOBCOL_DEF].size,
- parse_mood_line, ¤t_mood);
osl_close_disk_object(&objs[BLOBCOL_DEF]);
if (ret < 0) {
osl_close_disk_object(&objs[BLOBCOL_DEF]);
if (ret < 0) {
- PARA_ERROR_LOG("unable to load mood %s: %d\n",
- (char *)objs[BLOBCOL_NAME].data, ret);
- destroy_mood(new_mood);
- current_mood = old_mood;
+ PARA_ERROR_LOG("unable to load mood %s: %s\n", (*m)->name,
+ PARA_STRERROR(-ret));
+ destroy_mood(*m);
- destroy_mood(old_mood);
- current_mood = new_mood;
- PARA_INFO_LOG("loaded mood %s\n", current_mood->name);
+ PARA_INFO_LOG("loaded mood %s\n", (*m)->name);
return 1;
}
/* returns -E_MOOD_LOADED on _success_ to terminate the loop */
return 1;
}
/* returns -E_MOOD_LOADED on _success_ to terminate the loop */
-static int mood_loop(struct osl_row *row, __a_unused void *private_data)
+static int mood_loop(struct osl_row *mood_row, void *data)
- int ret = load_mood(row);
+ struct mood **m = data;
+ int ret = load_mood(mood_row, m);
if (ret < 0) {
if (ret != -E_DUMMY_ROW)
PARA_NOTICE_LOG("invalid mood (%d), trying next mood\n", ret);
if (ret < 0) {
if (ret != -E_DUMMY_ROW)
PARA_NOTICE_LOG("invalid mood (%d), trying next mood\n", ret);
-static int load_first_available_mood(void)
+static int load_first_available_mood(struct mood **m)
- int ret = osl_rbtree_loop(moods_table, BLOBCOL_NAME, NULL,
+ int ret = osl_rbtree_loop(moods_table, BLOBCOL_NAME, m,
mood_loop);
if (ret == -E_MOOD_LOADED) /* success */
return 1;
mood_loop);
if (ret == -E_MOOD_LOADED) /* success */
return 1;
/** The temporary array of admissible files. */
struct admissible_array {
/** The temporary array of admissible files. */
struct admissible_array {
+ /** Files are admissible wrt. this mood. */
+ struct mood *m;
/** The size of the array */
unsigned size;
/** Pointer to the array of admissible files. */
/** The size of the array */
unsigned size;
/** Pointer to the array of admissible files. */
*
* \return Negative on errors, positive on success.
*/
*
* \return Negative on errors, positive on success.
*/
-static int add_if_admissible(struct osl_row *aft_row, void *private_data)
+static int add_if_admissible(struct osl_row *aft_row, void *data)
+ struct admissible_array *aa = data;
- struct admissible_array *aa = private_data;
- score = 0;
- ret = compute_mood_score(aft_row, current_mood, &score);
+ ret = compute_mood_score(aft_row, aa->m, &score);
if (ret < 0)
return (ret == -E_NOT_ADMISSIBLE)? 1 : ret;
if (statistics.num >= aa->size) {
if (ret < 0)
return (ret == -E_NOT_ADMISSIBLE)? 1 : ret;
if (statistics.num >= aa->size) {
- * Compute the new score of an audio file.
+ * Compute the new score of an audio file wrt. the current mood.
*
* \param aft_row Determines the audio file.
* \param old_afsi The audio file selector info before updating.
*
* \param aft_row Determines the audio file.
* \param old_afsi The audio file selector info before updating.
+ * Change the current mood.
*
* \param mood_name The name of the mood to open.
*
*
* \param mood_name The name of the mood to open.
*
* the dummy mood that accepts every audio file and uses a scoring method
* based only on the \a last_played information.
*
* the dummy mood that accepts every audio file and uses a scoring method
* based only on the \a last_played information.
*
+ * If there is already an open mood, it will be closed first.
+ *
* \return Positive on success, negative on errors. Loading the dummy mood
* always succeeds.
*
* \sa struct admissible_file_info, struct admissible_array, struct
* afs_info::last_played, mood_close().
*/
* \return Positive on success, negative on errors. Loading the dummy mood
* always succeeds.
*
* \sa struct admissible_file_info, struct admissible_array, struct
* afs_info::last_played, mood_close().
*/
-int mood_open(char *mood_name)
+int change_current_mood(char *mood_name)
{
int i, ret;
struct admissible_array aa = {
{
int i, ret;
struct admissible_array aa = {
- ret = load_first_available_mood();
+ struct mood *m;
+ ret = load_first_available_mood(&m);
+ destroy_mood(current_mood);
+ current_mood = m;
struct osl_row *row;
struct osl_object obj = {
.data = mood_name,
struct osl_row *row;
struct osl_object obj = {
.data = mood_name,
PARA_NOTICE_LOG("no such mood: %s\n", mood_name);
return ret;
}
PARA_NOTICE_LOG("no such mood: %s\n", mood_name);
return ret;
}
+ ret = load_mood(row, &m);
+ destroy_mood(current_mood);
+ current_mood = m;
} else {
destroy_mood(current_mood);
current_mood = alloc_new_mood("dummy");
}
} else {
destroy_mood(current_mood);
current_mood = alloc_new_mood("dummy");
}
PARA_NOTICE_LOG("loaded mood %s\n", current_mood->name);
PARA_INFO_LOG("%s\n", "computing statistics of admissible files");
ret = audio_file_loop(&aa, add_if_admissible);
PARA_NOTICE_LOG("loaded mood %s\n", current_mood->name);
PARA_INFO_LOG("%s\n", "computing statistics of admissible files");
ret = audio_file_loop(&aa, add_if_admissible);
* Free all resources of the current mood which were allocated during
* mood_open().
*/
* Free all resources of the current mood which were allocated during
* mood_open().
*/
+void close_current_mood(void)
{
destroy_mood(current_mood);
current_mood = NULL;
{
destroy_mood(current_mood);
current_mood = NULL;
*
* \sa mood_open(), mood_close().
*/
*
* \sa mood_open(), mood_close().
*/
+int reload_current_mood(void)
{
int ret;
char *mood_name;
{
int ret;
char *mood_name;
return 1;
score_shutdown(0);
mood_name = para_strdup(current_mood->name);
return 1;
score_shutdown(0);
mood_name = para_strdup(current_mood->name);
- mood_close();
- ret = mood_open(mood_name);
+ close_current_mood();
+ ret = change_current_mood(mood_name);
free(mood_name);
return ret;
}
free(mood_name);
return ret;
}