do not use STDIN as a fd for select
authorAndre <maan@p133.(none)>
Thu, 15 Jun 2006 13:10:53 +0000 (15:10 +0200)
committerAndre <maan@p133.(none)>
Thu, 15 Jun 2006 13:10:53 +0000 (15:10 +0200)
It was a bad idea to do this to speed up scrolling as it confuses ncurses and
got even worse for nonblocking stdin.

Just decrease the select timeout instead.

gui.c

diff --git a/gui.c b/gui.c
index ab66bbb..cea54ab 100644 (file)
--- a/gui.c
+++ b/gui.c
@@ -893,8 +893,6 @@ repeat:
        /* command pipe only for COMMAND_MODE */
        if (command_pipe >= 0 && mode == COMMAND_MODE)
                para_fd_set(command_pipe, &rfds, &max_fileno);
-       if (curses_active)
-               para_fd_set(STDIN_FILENO, &rfds, &max_fileno);
        ret = para_select(max_fileno + 1, &rfds, NULL, &tv);
        if (ret <= 0)
                goto check_return; /* skip fd checks */
@@ -1341,11 +1339,6 @@ int main(int argc, char *argv[])
        initscr(); /* needed only once, always successful */
        init_curses();
        print_welcome();
-       ret = mark_fd_nonblock(STDIN_FILENO);
-       if (ret < 0) {
-               PARA_EMERG_LOG("%s\n", PARA_STRERROR(-ret));
-               exit(EXIT_FAILURE);
-       }
        for (;;) {
                print_status_bar();
                ret = do_select(GETCH_MODE);