fn->private_data = NULL;
}
-#define OGGDEC_OUTPUT_CHUNK_SIZE (64 * 1024)
+#define OGGDEC_OUTPUT_CHUNK_SIZE (640 * 1024)
static int oggdec_execute(struct btr_node *btrn, const char *cmd, char **result)
{
struct btr_node *btrn = fn->btrn;
int ret, oret;
size_t iqs;
+ struct OggVorbis_File *vf = para_malloc(sizeof(*vf));
- pod->vf = para_malloc(sizeof(struct OggVorbis_File));
PARA_NOTICE_LOG("iqs: %zu, min_iqs: %zu, opening ov callbacks\n",
btr_get_input_queue_size(btrn), fn->min_iqs);
open:
- oret = ov_open_callbacks(fn, pod->vf,
+ oret = ov_open_callbacks(fn, vf,
NULL, /* no initial buffer */
0, /* no initial bytes */
ovc); /* the ov_open_callbacks */
ret = -E_OGGDEC_FAULT;
if (oret < 0)
goto out;
- pod->channels = ov_info(pod->vf, 0)->channels;
- pod->sample_rate = ov_info(pod->vf, 0)->rate;
+ pod->channels = ov_info(vf, 0)->channels;
+ pod->sample_rate = ov_info(vf, 0)->rate;
PARA_NOTICE_LOG("%d channels, %d Hz\n", pod->channels,
pod->sample_rate);
ret = 1;
out:
- if (ret <= 0) {
- free(pod->vf);
- pod->vf = NULL;
- } else {
+ if (ret <= 0)
+ free(vf);
+ else {
btr_consume(btrn, pod->converted);
pod->converted = 0;
fn->min_iqs = 0;
+ pod->vf = vf;
}
return ret;
}
struct private_oggdec_data *pod = fn->private_data;
struct btr_node *btrn = fn->btrn;
int ret, ns;
+ char *out;
+ ssize_t read_ret, have;
pod->converted = 0;
t->error = 0;
if (ret <= 0)
goto out;
}
- for (;;) {
- char *out = para_malloc(OGGDEC_OUTPUT_CHUNK_SIZE);
- ssize_t read_ret = ov_read(pod->vf, out, OGGDEC_OUTPUT_CHUNK_SIZE,
+ out = para_malloc(OGGDEC_OUTPUT_CHUNK_SIZE);
+ for (have = 0;;) {
+ read_ret = ov_read(pod->vf, out + have,
+ OGGDEC_OUTPUT_CHUNK_SIZE - have,
ENDIAN, 2 /* 16 bit */, 1 /* signed */, NULL);
btr_consume(btrn, pod->converted);
pod->converted = 0;
if (read_ret <= 0)
- free(out);
- ret = ns;
- if (read_ret == OV_HOLE) /* avoid buffer underruns */
- fn->min_iqs = 9000;
- if (read_ret == 0 || read_ret == OV_HOLE)
- goto out;
- ret = -E_OGGDEC_BADLINK;
- if (read_ret < 0)
- goto out;
- btr_add_output(out, read_ret, btrn);
+ break;
+ have += read_ret;
+ if (have >= OGGDEC_OUTPUT_CHUNK_SIZE)
+ break;
+ }
+ if (have == 0)
+ free(out);
+ else if (have < OGGDEC_OUTPUT_CHUNK_SIZE)
+ out = para_realloc(out, have);
+ if (have > 0) {
+ btr_add_output(out, have, btrn);
fn->min_iqs = 0;
- if (btr_get_output_queue_size(btrn) > 128 * 1024)
- return; /* enough data for the moment */
}
+ ret = ns;
+ if (read_ret == OV_HOLE) /* avoid buffer underruns */
+ fn->min_iqs = 9000;
+ if (read_ret == 0 || read_ret == OV_HOLE)
+ goto out;
+ ret = -E_OGGDEC_BADLINK;
+ if (read_ret < 0)
+ goto out;
+ ret = 0;
out:
if (ret < 0) {
t->error = ret;