14 years agoIntroduce para_sigaction().
Andre Noll [Mon, 6 Apr 2009 15:53:46 +0000 (17:53 +0200)]
Introduce para_sigaction().

This wrapper for sigaction() is public and may be used to setup
a handler different from the generic handler that gets installed
for the signal by para_install_sighandler().

14 years agosignal: Switch from signal() to sigaction.
Andre Noll [Mon, 6 Apr 2009 15:45:44 +0000 (17:45 +0200)]
signal: Switch from signal() to sigaction.

Use of signal() should be avoided because the behavior of signal() varies
across Unix versions, and has also varied historically across different
versions of Linux.

This patch rewrites para_install_sighandler so that it calls sigaction()
instead of signal(). The implementation is taken from good old APUE.

There are a couple of other users of signal() in the paraslash code. Most
of which are OK because they use signal() only to ignore/reset a signal which
happens to be the only portable use of signal(). All other users of signal()
have to be converted in subsequent patches.

14 years agoAuto-adjust fecdec output buffer size.
Andre Noll [Sat, 28 Mar 2009 18:15:01 +0000 (19:15 +0100)]
Auto-adjust fecdec output buffer size.

14 years agoFix a memory leak in the fecdec filter.
Andre Noll [Sat, 28 Mar 2009 18:13:56 +0000 (19:13 +0100)]
Fix a memory leak in the fecdec filter.

14 years agofecdec: Return an error on zero size slices.
Andre Noll [Sat, 28 Mar 2009 18:13:23 +0000 (19:13 +0100)]
fecdec: Return an error on zero size slices.

14 years agoINSTALL: Minor improvements.
Andre Noll [Sun, 22 Mar 2009 18:53:27 +0000 (19:53 +0100)]
INSTALL: Minor improvements.

14 years agoFix some memory leaks.
Andre Noll [Sun, 22 Mar 2009 12:58:28 +0000 (13:58 +0100)]
Fix some memory leaks.

In fact, there was only one "real" leak: An empty info string (100
bytes) could leak on file change.

14 years agoDestroy the close_on_fork_list in close_listed_fds().
Andre Noll [Sun, 22 Mar 2009 11:23:21 +0000 (12:23 +0100)]
Destroy the close_on_fork_list in close_listed_fds().

This is called from child context and the child does no longer
need the list once all fds have been closed.

14 years agoserver: Use a temporary SIGCHLD handler to catch afs init failures.
Andre Noll [Sat, 21 Mar 2009 16:46:43 +0000 (17:46 +0100)]
server: Use a temporary SIGCHLD handler to catch afs init failures.

If afs dies immediately on startup (because of dirty tables) para_server
would not notice as the SIGCHLD handler is being intalled after the
call to afs_init().

14 years agoaudiod: Improve display of play time.
Andre Noll [Thu, 19 Mar 2009 21:51:17 +0000 (22:51 +0100)]
audiod: Improve display of play time.

Keeping track of the offset, server stream start and the duration
of the audio file length at the time the receiver/writer was started
allows to compute the play time more accurately.

14 years agoFix various dead stores found by the clang static analyzer.
Andre Noll [Wed, 18 Mar 2009 22:05:22 +0000 (23:05 +0100)]
Fix various dead stores found by the clang static analyzer.

14 years agoudp_send: Also mention the FEC parameters of all targets.
Andre Noll [Wed, 18 Mar 2009 19:16:03 +0000 (20:16 +0100)]
udp_send: Also mention the FEC parameters of all targets.

14 years agowav: Replace assertion by a proper error message.
Andre Noll [Wed, 18 Mar 2009 19:15:27 +0000 (20:15 +0100)]
wav: Replace assertion by a proper error message.

This assertion can be hit easily by choosing wav as the first filter
of the filter chain.

14 years agoGET_NUM_DIGITS: Evaluate macro parameter only once.
Andre Noll [Tue, 17 Mar 2009 23:00:08 +0000 (00:00 +0100)]
GET_NUM_DIGITS: Evaluate macro parameter only once.

14 years agoFix possible NULL pointer dereference in afh_get_header().
Andre Noll [Tue, 17 Mar 2009 22:58:58 +0000 (23:58 +0100)]
Fix possible NULL pointer dereference in afh_get_header().

14 years agomp3: Avoid rounding errors during bitrate calculation.
Andre Noll [Sun, 15 Mar 2009 17:59:48 +0000 (18:59 +0100)]
mp3: Avoid rounding errors during bitrate calculation.

Just add up the bitrates of all frames and divide by the number
of frames afterwards. By using uint64_t for the sum, we should
be safe wrt. overflows.

14 years agoFix year in comment to color.c.
Andre Noll [Sun, 15 Mar 2009 16:36:19 +0000 (17:36 +0100)]
Fix year in comment to color.c.

The code was actually stolen this year :)

14 years agoalsa: Split alsa_open().
Andre Noll [Sun, 15 Mar 2009 16:35:37 +0000 (17:35 +0100)]
alsa: Split alsa_open().

Only perform what is absolutely necessary in alsa_open(). Call the
real alsa initialization from alsa_post_select(), when we actually
have audio data available to start streaming.

This should get rid of the sound artefacts that happen sometimes
at the beginning of the stream.

14 years agowrite: Get rid of wn->chunk_bytes and wng->max_chunk_bytes.
Andre Noll [Sun, 15 Mar 2009 16:14:50 +0000 (17:14 +0100)]
write: Get rid of wn->chunk_bytes and wng->max_chunk_bytes.

These are not used anyway. Make all writers return 1 on success.

14 years agoMinor documentation updates.
Andre Noll [Sun, 15 Mar 2009 16:08:14 +0000 (17:08 +0100)]
Minor documentation updates.

14 years agoalsa: Simplify alsa_open().
Andre Noll [Sun, 15 Mar 2009 14:47:45 +0000 (15:47 +0100)]
alsa: Simplify alsa_open().

No need to call snd_pcm_info() as we do not use it anyway.

14 years agoaudiod: Improve receiver restart logic.
Andre Noll [Sun, 15 Mar 2009 14:29:12 +0000 (15:29 +0100)]
audiod: Improve receiver restart logic.

Use the vss status flags and the stream_start time announced by
para_server to decide when to start a new receiver.

This is better than basing this decision only on whether the vss status
equals "playing" as we did before. This allows to reliably detect when it
is safe to start a new receiver while the filter/writer of the current
stream are still active.

The old code would simply wait until filter/writer complete which, due to
buffering, might be much too late.

14 years agovss: Take fec group durations into account when computing the eof barrier.
Andre Noll [Thu, 12 Mar 2009 20:39:59 +0000 (21:39 +0100)]
vss: Take fec group durations into account when computing the eof barrier.

On eof, we must wait at least as long as the duration of the last sent
fec group.

14 years agoFix a typo in the documentation to struct writer.
Andre Noll [Thu, 12 Mar 2009 20:38:07 +0000 (21:38 +0100)]
Fix a typo in the documentation to struct writer.

14 years agoalsa: Revert 596d1d97f90854bd941db02f1353df8e1196ccc0
Andre Noll [Thu, 12 Mar 2009 20:37:26 +0000 (21:37 +0100)]
alsa: Revert 596d1d97f90854bd941db02f1353df8e1196ccc0

This was really a brain fart. Instead, introduce a small delay
in alsa_open() that defers audio data writing by 100ms. This seems
to be enough to get rid of the buffer underruns with the udp sender.

14 years agoaudiod: Change return value of open_current_receiver() to void.
Andre Noll [Mon, 9 Mar 2009 21:43:04 +0000 (22:43 +0100)]
audiod: Change return value of open_current_receiver() to void.

Its single caller ignores the return value.

14 years agoMove struct status_task from audiod.h to audiod.c.
Andre Noll [Mon, 9 Mar 2009 21:35:11 +0000 (22:35 +0100)]
Move struct status_task from audiod.h to audiod.c.

It's only used in audiod.c.

14 years agovss: Fix need_audio_header().
Andre Noll [Mon, 9 Mar 2009 21:01:33 +0000 (22:01 +0100)]
vss: Fix need_audio_header().

This braino caused the audio file header to be included in each FEC group.

14 years agovss: Improve EOF handling.
Andre Noll [Mon, 9 Mar 2009 20:55:50 +0000 (21:55 +0100)]
vss: Improve EOF handling.

Set the "next" flag only if no more writes to fec clients happen.

14 years agovss: Handle errors in setup_next_fec_group() properly.
Andre Noll [Mon, 9 Mar 2009 20:41:36 +0000 (21:41 +0100)]
vss: Handle errors in setup_next_fec_group() properly.

setup_next_fec_group() might return a negative value.

14 years agorecv_afs_msg(): Fix indentation.
Andre Noll [Mon, 9 Mar 2009 20:29:27 +0000 (21:29 +0100)]
recv_afs_msg(): Fix indentation.

14 years agoMake FEC work with oggvorbis streams.
Andre Noll [Sun, 8 Mar 2009 20:41:27 +0000 (21:41 +0100)]
Make FEC work with oggvorbis streams.

Unfortunately, this required to rewrite large parts of the fec code
in vss.c. The new code behaves better if the FEC parameters are not
suitable for the current audio file, for example if the audio file header
does not fit into the desired number of slices. It detects this situation
and adjusts the given FEC parameters accordingly.

14 years agoafh: Introduce afh_get_largest_chunk_size().
Andre Noll [Sun, 8 Mar 2009 18:59:17 +0000 (19:59 +0100)]
afh: Introduce afh_get_largest_chunk_size().

This will be needed by the fec code in order to validate the
fec parameters.

14 years agooggdec: Abort on input errors.
Andre Noll [Sun, 8 Mar 2009 18:58:08 +0000 (19:58 +0100)]
oggdec: Abort on input errors.

14 years agofec: Fix comment to invert_mat().
Andre Noll [Sun, 8 Mar 2009 18:56:53 +0000 (19:56 +0100)]
fec: Fix comment to invert_mat().

14 years agoalsa_write: Handle EPIPE errors properly.
Andre Noll [Thu, 5 Mar 2009 21:05:22 +0000 (22:05 +0100)]
alsa_write: Handle EPIPE errors properly.

There's no need to throw away the data if a buffer underrun occurs.
Just try to write the same data again after the snd_pcm_prepare().

14 years agoAvoid division by zero in setup_next_fec_group().
Andre Noll [Thu, 5 Mar 2009 21:03:14 +0000 (22:03 +0100)]
Avoid division by zero in setup_next_fec_group().

This needs more work.

14 years agoFix initialization of fec_client_list.
Andre Noll [Thu, 5 Mar 2009 21:00:41 +0000 (22:00 +0100)]
Fix initialization of fec_client_list.

The list must be initialized _before_ the init functions of the
senders are called, because the udp_send_init() might add fec clients
to that list.

14 years agoNEWS, CREDITS, FEATURES update.
Andre Noll [Wed, 4 Mar 2009 21:58:23 +0000 (22:58 +0100)]

14 years agoRecognize the eof packet also in the udp receiver.
Andre Noll [Wed, 4 Mar 2009 21:19:04 +0000 (22:19 +0100)]
Recognize the eof packet also in the udp receiver.

This fixes two bugs: The last fec group of an audio file was not
decoded at all, and "para_recv -r udp" did not exit at the end of
a multicast stream.

14 years agoFix some gcc warnings on x86_64.
Andre Noll [Mon, 2 Mar 2009 10:07:01 +0000 (11:07 +0100)]
Fix some gcc warnings on x86_64.

14 years agoMerge commit 'meins/master'
Andre Noll [Mon, 2 Mar 2009 09:39:59 +0000 (10:39 +0100)]
Merge commit 'meins/master'

14 years agovss.c: Improve the fec timing code.
Andre Noll [Sun, 1 Mar 2009 22:09:51 +0000 (23:09 +0100)]
vss.c: Improve the fec timing code.

This patch

- Fixes a the bug where assert(start_buf) caused para_server
to abort.
- Gets rid of buffer underruns by introducing a quick hack that
sends all but the first slice a bit early.
- Moves some code from compute_next_fec_slice() to
setup_next_fec_group() where it belongs.

14 years agoSimplify dispatch_slice().
Andre Noll [Sun, 1 Mar 2009 21:10:53 +0000 (22:10 +0100)]
Simplify dispatch_slice().

14 years agofecdec: Add some more documentation, minor improvements.
Andre Noll [Sun, 1 Mar 2009 21:08:23 +0000 (22:08 +0100)]
fecdec: Add some more documentation, minor improvements.

14 years agofecdec: Minor cleanups.
Andre Noll [Sun, 1 Mar 2009 20:54:24 +0000 (21:54 +0100)]
fecdec: Minor cleanups.

14 years agofecdec.c: Add some more sanity checks to find_group().
Andre Noll [Sun, 1 Mar 2009 20:09:37 +0000 (21:09 +0100)]
fecdec.c: Add some more sanity checks to find_group().

14 years agoMake fec parameters configurable.
Andre Noll [Sun, 1 Mar 2009 18:26:04 +0000 (19:26 +0100)]
Make fec parameters configurable.

This patch allows to specify the fec parameters in the add subcommand
like this:

para_client sender udp add

14 years agoMore source code documentation.
Andre Noll [Sun, 1 Mar 2009 13:57:52 +0000 (14:57 +0100)]
More source code documentation.

14 years agovss.h: Kill unused VSS_CHANGE.
Andre Noll [Sun, 1 Mar 2009 13:43:25 +0000 (14:43 +0100)]
vss.h: Kill unused VSS_CHANGE.

14 years agofecdec.c: Don't warn about incomplete slices at close time.
Andre Noll [Sun, 1 Mar 2009 13:42:39 +0000 (14:42 +0100)]
fecdec.c: Don't warn about incomplete slices at close time.

Move that warning to free_oldest_group().

14 years agofecdec_filter.c: Kill useless UNUSED_GROUP_NUM.
Andre Noll [Sun, 1 Mar 2009 13:00:40 +0000 (14:00 +0100)]
fecdec_filter.c: Kill useless UNUSED_GROUP_NUM.

A group is complete iff num_received_slices >= data_slices_per_group.

14 years agofecdec_filter cleanups and documentation improvements.
Andre Noll [Sun, 1 Mar 2009 12:55:29 +0000 (13:55 +0100)]
fecdec_filter cleanups and documentation improvements.

Rename struct fec_group to fecdec_group as we already have struct
fec_group in vss.c. Also kill useless INPUT_BUFFER_SIZE define.

14 years agoAdd some more FEC source code documentation.
Andre Noll [Sun, 1 Mar 2009 12:24:31 +0000 (13:24 +0100)]
Add some more FEC source code documentation.

14 years agoTrivial doxygen fixes.
Andre Noll [Sat, 28 Feb 2009 21:56:47 +0000 (22:56 +0100)]
Trivial doxygen fixes.

14 years agoDefine _GNU_SOURCE to get the ucred structure.
Andre Noll [Sat, 28 Feb 2009 21:39:50 +0000 (22:39 +0100)]
Define _GNU_SOURCE to get the ucred structure.

This is needed for glibc >= 2.8.

14 years agoSimplify compute_slice_timeout().
Andre Noll [Sat, 28 Feb 2009 17:21:55 +0000 (18:21 +0100)]
Simplify compute_slice_timeout().

14 years agovss.c: Get rid of some casts.
Andre Noll [Sat, 28 Feb 2009 14:09:13 +0000 (15:09 +0100)]
vss.c: Get rid of some casts.

14 years agoMerge branch 'gerrit'
Andre Noll [Sat, 28 Feb 2009 13:56:11 +0000 (14:56 +0100)]
Merge branch 'gerrit'

14 years agoAdd forward error correction code to the udp sender/receiver.
Andre Noll [Sat, 28 Feb 2009 13:55:46 +0000 (14:55 +0100)]
Add forward error correction code to the udp sender/receiver.

This patch adds the first draft of a FEC implementation based
on code by Luigi Rizzo.

On the server side, the FEC encoding is done within the virtual
streaming system which also contains the timing routines for sending
a FEC-encoded audio stream. Senders my request such an encoded stream
by calling vss_add_fec_client() with a fec_client_parms structure
that contains the FEC parameters and a callback function which is used
to actually send the data.

On the receiver side, the new fecdec filter is introduced which must
be used to decode a FEC-encoded stream. As the fec parameters are
contained in the header of each data slice of the encoded stream, no
options to this filter are necessary.

ATM, FEC is only used by the udp sender/receiver, but other protocols
can be easily changed to use FEC as well.

This new code is still experimental, lacks documentation and the fec
parameters can currently only be changed by editing the source code.

14 years agoURL/UDPv6 support for the UDP sender.
Gerrit Renker [Sat, 28 Feb 2009 12:40:01 +0000 (13:40 +0100)]
URL/UDPv6 support for the UDP sender.

This adds support for URL strings to support IPv4/IPv6 addresses, hostnames,
and optional port numbers to the UDP sender. The syntax is based on RFC 3986,
example URL strings to be used with the 'add'/'delete' commands are: # host:port # host with default port 8000
     localhost # hostname (for IPv4 or IPv6 host)
     localhost:8001 # hostname with port
     [::1]:8000  # same, but different syntax
     [badc0de::1] # IPv6 host with default port 8000

The 'delete' command now also supports port-wildcarding, i.e. not specifying
the port in the 'delete' command removes all targets whose host names match.

The UDP sender has been tested to function with IPv6, including multicasting:
 * server: para_server --udp_target=[ff05::beef]:8000 --udp_mcast_iface=eth1
 * client: para_audiod -F -D -r 'ogg:udp -i ff05::beef -I eth0'

14 years agoAuxiliary functions to parse and validate parts of URIs.
Gerrit Renker [Sat, 28 Feb 2009 12:40:01 +0000 (13:40 +0100)]
Auxiliary functions to parse and validate parts of URIs.

To support URI syntax in the manner of RFC 3986, this adds a self-contained set
of functions to parse (parts of) URIs and to validate such parts using basic
syntax checks.

To avoid blocking while resolving DNS strings, strings that do not have the
characteristics of native IPv4/v6 address strings always pass; a wrong hostname
will then be detected later when connecting.

Note: strictly speaking, this does not deal with URIs, since the 'scheme' part
      is missing and only the "locator" part is parsed. It is possible to extend
      this later, using something like dccp://host[:port], http://host[:port],
      or udp://host[:port] to specify the transport protocols of paraslash.

14 years agoaacdec: Do not fail on emtpy buffers.
Andre Noll [Sat, 28 Feb 2009 11:45:51 +0000 (12:45 +0100)]
aacdec: Do not fail on emtpy buffers.

14 years agoalsa: Do not fail if sw params could not be installed.
Andre Noll [Mon, 23 Feb 2009 13:24:42 +0000 (14:24 +0100)]
alsa: Do not fail if sw params could not be installed.

This is not fatal, so just print a warining.

14 years agoSimplify client_open().
Andre Noll [Fri, 20 Feb 2009 21:47:06 +0000 (22:47 +0100)]
Simplify client_open().

Use the file_exists() helper and add missing documenation for
the loglevel arg.

14 years agoMerge commit 'fml/master'
Andre Noll [Mon, 16 Feb 2009 22:38:16 +0000 (23:38 +0100)]
Merge commit 'fml/master'

14 years agoPut IPv4-specific parts inside the ACL subsystem
Gerrit Renker [Sat, 7 Feb 2009 19:16:50 +0000 (20:16 +0100)]
Put IPv4-specific parts inside the ACL subsystem

The ACL subsystem performs access validation based on IPv4 address /
netmask pairs. Since the internals of this system are exposed via
struct sender_command_data, other subsystems can only use IPv4.

This patch migrates the IPv4-specific parts of the ACL subsystem inside
that system and replaces the 'struct in_addr' address with a host
string. A subsequent patch converts the remaining subsystems to also
use strings instead of AF-dependent addresses.

For the present purpose the string size (fixed) is over-dimensioned,
since a valid IPv4 address contains at most 15 = 4*3 + 3 + 1 bytes
(including the 3 dots and the '\0'). The size should also be sufficient
for hostnames, since RFC 1123, 2.1 suggests a maximum length of 255.

Since the conversion string -> struct in_addr now happens later,
syntax checks have been added for argument strings.

14 years agoTypos
Gerrit Renker [Sat, 7 Feb 2009 18:06:31 +0000 (19:06 +0100)]

Found when rtfm.

14 years agoAllow to specify UDPv4/6 multicast interface
Gerrit Renker [Sat, 14 Feb 2009 17:36:42 +0000 (18:36 +0100)]
Allow to specify UDPv4/6 multicast interface

Using a Posix function, this allows to specify outgoing/incoming
multicast interfaces, e.g.

  para_server --udp_target= --udp_mcast_iface=eth1


  para_audiod -D -r 'ogg:udp -i -I eth0'

The option simplifies multicast streaming, which is now possible without
having to set a multicast route when there is more than one network interface.

This option works unconditionally for UDPv6. For UDPv4 it is only enabled
on hosts that support `struct ip_mreqn', support for which is detected
via configure.

On OSes that do not support this struct, a warning message is printed;
while it is possible to add the same functionality also in those cases,
it would complicate the implementation and thus has been left out.

14 years agoSupport for UDPv4/v6 multicast streaming
Gerrit Renker [Mon, 2 Feb 2009 19:58:49 +0000 (20:58 +0100)]
Support for UDPv4/v6 multicast streaming

This provides self-contained support for UDPv4/v6 multicast:
 * receiver joins multicast v4/v6 address;
 * sender, on encountering a multicast address, sets TTL/IPv6
   number of multicast hops, and (as a precaution) enables looping
   back of multicast packets.

The use of the sender is still restricted to UDPv4, since it is also
necessary to perform changes to the (IPv4-based) udp_target struct,
which should be done in a separate patch.

14 years agoFix a typo in gui.c.
Andre Noll [Sun, 15 Feb 2009 17:12:19 +0000 (18:12 +0100)]
Fix a typo in gui.c.

14 years agoMerge commit 'fml/master'
Andre Noll [Wed, 11 Feb 2009 22:56:24 +0000 (23:56 +0100)]
Merge commit 'fml/master'

14 years agoFix the ROUND_UP macro.
Andre Noll [Wed, 11 Feb 2009 21:18:17 +0000 (22:18 +0100)]
Fix the ROUND_UP macro.


14 years agoDo not allocate too much space for the mp3 chunk table.
Andre Noll [Wed, 11 Feb 2009 21:17:42 +0000 (22:17 +0100)]
Do not allocate too much space for the mp3 chunk table.

The chunk_table contains an array of uint32_t values.

14 years agoMerge commit 'fml/master'
Andre Noll [Tue, 10 Feb 2009 07:44:02 +0000 (08:44 +0100)]
Merge commit 'fml/master'

14 years agoMerge commit 'meins/master'
Andre Noll [Mon, 9 Feb 2009 19:37:04 +0000 (20:37 +0100)]
Merge commit 'meins/master'

14 years agoMerge commit 'meins/master'
Andre Noll [Fri, 6 Feb 2009 17:01:53 +0000 (18:01 +0100)]
Merge commit 'meins/master'

14 years agoafs.cmd: Add documentation of ls -lc.
Andre Noll [Wed, 4 Feb 2009 21:33:04 +0000 (22:33 +0100)]
afs.cmd: Add documentation of ls -lc.

14 years agoattribute.c: Trivial docu fix.
Andre Noll [Wed, 4 Feb 2009 21:32:34 +0000 (22:32 +0100)]
attribute.c: Trivial docu fix.

14 years agoIgnore SIGUSR1 before forking the afs process.
Andre Noll [Wed, 4 Feb 2009 21:27:29 +0000 (22:27 +0100)]
Ignore SIGUSR1 before forking the afs process.

Otherwise, afs might get killed by SIGUSR1 before it gets a chance
to ignore this signal.

14 years agoafs: Fix a shm leak.
Andre Noll [Wed, 4 Feb 2009 21:25:55 +0000 (22:25 +0100)]
afs: Fix a shm leak.

Even if the command handler stops to read the command output
afs must continue to read shmids from server fd so that it can
destroy all shared memory areas that the server created for afs.

14 years agoCall shm(destroy) on the mmd shared memory area right after creating it.
Andre Noll [Tue, 3 Feb 2009 20:41:08 +0000 (21:41 +0100)]
Call shm(destroy) on the mmd shared memory area right after creating it.

It will only be destroyed when the last reference is gone, which
is when para_server exits. This allows to get rid of a global
variable. Moreover, the shared memory area will be destroyed even
in case para_server crashes.

14 years agoSimplify ggo/makefile.
Gerrit Renker [Tue, 27 Jan 2009 10:46:27 +0000 (11:46 +0100)]
Simplify ggo/makefile.

Use a define rather than shell code to compute the options to gengetopt.

14 years agoFix config file handling for audiod and clean up init functions.
Andre Noll [Mon, 26 Jan 2009 22:27:50 +0000 (23:27 +0100)]
Fix config file handling for audiod and clean up init functions.

As noted by Gerrit Renker, audiod refused to start if the --config_file
option was not given and the default config file does not exist.

Fix this bug and rename some of the init functions to make the naming
more consistent.

14 years agoMerge commit 'fml/master'
Andre Noll [Mon, 26 Jan 2009 19:38:08 +0000 (20:38 +0100)]
Merge commit 'fml/master'

14 years agoFix build as root.
Andre Noll [Mon, 26 Jan 2009 13:19:19 +0000 (14:19 +0100)]
Fix build as root.

As noted by Gerrit Renker, when trying to extract help text from
./para_audiod, the build stops when logged in as root because
para_audiod refuses to start as root if --user and --group are
not given.

This patch moves the check for UID==0 after the check for --help and
--detailed-help so that the help text may be extracted as root even
if no --user and --group options are given.

14 years agoBuild problem when no audiod.conf exists
Gerrit Renker [Sat, 24 Jan 2009 22:37:04 +0000 (23:37 +0100)]
Build problem when no audiod.conf exists

This avoids stopping the build process and allows users to read
the detailed help before getting the error message about a missing
audiod.conf file - fixed by parsing after testing for the help text.

14 years agoDon't let make write the filename into the output
Gerrit Renker [Sat, 24 Jan 2009 20:50:09 +0000 (21:50 +0100)]
Don't let make write the filename into the output

The 'cd' output in the command echoed the directory into the
output, which is not welcome in the output file (gengetopt
did not like that).

14 years agoFix para_client's --loglevel option.
Andre Noll [Sat, 24 Jan 2009 14:08:43 +0000 (15:08 +0100)]
Fix para_client's --loglevel option.

Without this fix, para_client always used loglevel debug.

14 years agoFix compile warning on NetBSD.
Andre Noll [Wed, 21 Jan 2009 15:43:41 +0000 (16:43 +0100)]
Fix compile warning on NetBSD.

This fixes

color.c:71: warning: array subscript has type 'char'

14 years agoosx_write.c: Add missing include.
Andre Noll [Wed, 21 Jan 2009 15:11:51 +0000 (16:11 +0100)]
osx_write.c: Add missing include.

14 years agoMerge commit 'meins/master'
Andre Noll [Mon, 19 Jan 2009 13:49:09 +0000 (14:49 +0100)]
Merge commit 'meins/master'

14 years agoMerge commit 'athcx/master'
Andre Noll [Sun, 18 Jan 2009 23:29:44 +0000 (00:29 +0100)]
Merge commit 'athcx/master'

14 years agomake_wav_header(): Add some comments.
Andre Noll [Sun, 18 Jan 2009 23:23:49 +0000 (00:23 +0100)]
make_wav_header(): Add some comments.

14 years agoserver.c: Only try to print errors when not in daemon mode.
Andre Noll [Sun, 18 Jan 2009 23:22:53 +0000 (00:22 +0100)]
server.c: Only try to print errors when not in daemon mode.

14 years agoUse symbolic names for loglevels and clean up the ggo mess.
Andre Noll [Sun, 18 Jan 2009 01:25:42 +0000 (02:25 +0100)]
Use symbolic names for loglevels and clean up the ggo mess.

We now use m4 to generate the ggo files, which allows to get rid of
a lot of duplicated command line options and improves the readability
of the man pages.

14 years agoAdd some more derived files to .gitignore.
Andre Noll [Sun, 18 Jan 2009 01:19:00 +0000 (02:19 +0100)]
Add some more derived files to .gitignore.

14 years agoMove gengetopt targets to own Makefile.
Andre Noll [Sat, 17 Jan 2009 18:59:35 +0000 (19:59 +0100)]
Move gengetopt targets to own Makefile.

14 years agoMove ggo files to a separate directory.
Andre Noll [Sat, 17 Jan 2009 18:22:14 +0000 (19:22 +0100)]
Move ggo files to a separate directory.

14 years agoMove color logging code to daemon.c and use it also for para_audiod.
Andre Noll [Fri, 16 Jan 2009 18:28:57 +0000 (19:28 +0100)]
Move color logging code to daemon.c and use it also for para_audiod.

This patch also introduces the para_log() function of daemon.c so that
both para_server and para_audiod can use it.